-
-
Notifications
You must be signed in to change notification settings - Fork 285
Add support for reporting an upstream version #4378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add support for reporting an upstream version #4378
Conversation
|
Would this be a good place / time to also add a canonical name field for easier matching with upstream? |
|
Yeah and that is within the discussion in JuliaPackaging/BinaryBuilder.jl#639 |
|
Pretty much everything I thought I knew about JLLs was wrong. This is wildly challenging.
|
|
I'm assuming @giordano has already seen this discussion, but pinging him just in case |
|
Instead of a single version number, could we store a dict with more detailed info? |
|
While adding stuff to the registry can be useful, I feel like for what Matt wants it'd be better to dump all the info we want into a file in the JLL repo, so that we don't need to care about cluttering the registry. Someone needs to champion designing the data we need and the format. I mentioned in JuliaPackaging/BinaryBuilder.jl#639 (comment) that some information (perhaps all?) has to be platform-specific, as Matt realised the hard way today. |
i.e. for JLLs whose package version is most likely not the same as the upstream version.
Currently we don't record the upstream version reliably from BB, but it's proving painful for advisory tracking (cc. @mbauman)
Here ImageMagick_jll has been modified to have a made up
upstream_versionfield in its Project.toml here