address review comments

Author: KristofferC

stdlib/Artifacts/src/Artifacts.jl

@@ -652,17 +652,17 @@ access a single file/directory within an artifact.  Example:
 !!! compat "Julia 1.6"
     Slash-indexing requires at least Julia 1.6.
 """
-macro artifact_str(name, platform=nothing, artifact_path=nothing)
+macro artifact_str(name, platform=nothing, artifacts_toml_path=nothing)
     # Find Artifacts.toml file we're going to load from
     srcfile = string(__source__.file)
     if ((isinteractive() && startswith(srcfile, "REPL[")) || (!isinteractive() && srcfile == "none")) && !isfile(srcfile)
         srcfile = pwd()
     end
     # Sometimes we know the exact path to the Artifacts.toml file, so we can save some lookups
-    local artifacts_toml = if artifact_path === nothing
+    local artifacts_toml = if artifacts_toml_path === nothing
         find_artifacts_toml(srcfile)
     else
-        artifact_path
+        artifacts_toml_path
     end
     if artifacts_toml === nothing
         error(string(

stdlib/Artifacts/test/runtests.jl

@@ -91,7 +91,7 @@ end
         HelloWorldC_exe_path = joinpath(HelloWorldC_dir, "bin", "hello_world$(exeext)")
         @test isfile(HelloWorldC_exe_path)
 
-        HelloWorldC_dir_explicit_artifact = eval(Expr(:macrocall, Symbol("@artifact_str"), nothing, "HelloWorldC", nothing, joinpath(@__DIR__, "Artifacts.toml")))
+        HelloWorldC_dir_explicit_artifact = eval(:(@artifact_str "HelloWorldC" joinpath(@__DIR__, "Artifacts.toml")))
         @test isdir(HelloWorldC_dir_explicit_artifact)
 
         # Simple slash-indexed lookup