Skip to content

Commit 1119f12

Browse files
authored
Revert "Deps: after configuring CMake project, use cmake --build, not make (#54538)" (#55285)
Fixes #55284.
1 parent 427824e commit 1119f12

File tree

9 files changed

+18
-14
lines changed

9 files changed

+18
-14
lines changed

deps/ittapi.mk

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ $(BUILDDIR)/$(ITTAPI_SRC_DIR)/build-configured: $(SRCCACHE)/$(ITTAPI_SRC_DIR)/so
1414
echo 1 > $@
1515

1616
$(BUILDDIR)/$(ITTAPI_SRC_DIR)/build-compiled: $(BUILDDIR)/$(ITTAPI_SRC_DIR)/build-configured
17-
$(CMAKE) --build $(dir $<)
17+
$(MAKE) -C $(dir $<)
1818
echo 1 > $@
1919

2020
define ITTAPI_INSTALL

deps/libgit2.mk

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,12 +51,12 @@ $(BUILDDIR)/$(LIBGIT2_SRC_DIR)/build-configured: $(LIBGIT2_SRC_PATH)/source-extr
5151
echo 1 > $@
5252

5353
$(BUILDDIR)/$(LIBGIT2_SRC_DIR)/build-compiled: $(BUILDDIR)/$(LIBGIT2_SRC_DIR)/build-configured
54-
$(CMAKE) --build $(dir $<)
54+
$(MAKE) -C $(dir $<)
5555
echo 1 > $@
5656

5757
$(BUILDDIR)/$(LIBGIT2_SRC_DIR)/build-checked: $(BUILDDIR)/$(LIBGIT2_SRC_DIR)/build-compiled
5858
ifeq ($(OS),$(BUILD_OS))
59-
$(CMAKE) --build $(dir $@) test
59+
$(MAKE) -C $(dir $@) test
6060
endif
6161
echo 1 > $@
6262

deps/libssh2.mk

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,12 +49,12 @@ $(BUILDDIR)/$(LIBSSH2_SRC_DIR)/build-configured: $(LIBSSH2_SRC_PATH)/source-extr
4949
echo 1 > $@
5050

5151
$(BUILDDIR)/$(LIBSSH2_SRC_DIR)/build-compiled: $(BUILDDIR)/$(LIBSSH2_SRC_DIR)/build-configured
52-
$(CMAKE) --build $(dir $<)
52+
$(MAKE) -C $(dir $<)
5353
echo 1 > $@
5454

5555
$(BUILDDIR)/$(LIBSSH2_SRC_DIR)/build-checked: $(BUILDDIR)/$(LIBSSH2_SRC_DIR)/build-compiled
5656
ifeq ($(OS),$(BUILD_OS))
57-
$(CMAKE) --build $(dir $@) test
57+
$(MAKE) -C $(dir $@) test
5858
endif
5959
echo 1 > $@
6060

deps/libsuitesparse.mk

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -59,8 +59,8 @@ $(BUILDDIR)/SuiteSparse-$(LIBSUITESPARSE_VER)/build-compiled: | $(build_prefix)/
5959

6060
$(BUILDDIR)/SuiteSparse-$(LIBSUITESPARSE_VER)/build-compiled: $(BUILDDIR)/SuiteSparse-$(LIBSUITESPARSE_VER)/source-patched
6161
cd $(dir $<) && $(CMAKE) . $(LIBSUITESPARSE_CMAKE_FLAGS)
62-
$(CMAKE) --build $(dir $<)
63-
$(CMAKE) --install $(dir $<)
62+
$(MAKE) -C $(dir $<)
63+
$(MAKE) -C $(dir $<) install
6464
echo 1 > $@
6565

6666
ifeq ($(OS),WINNT)
@@ -70,7 +70,7 @@ LIBSUITESPARSE_SHLIB_ENV:=LD_LIBRARY_PATH="$(build_shlibdir)"
7070
endif
7171
$(BUILDDIR)/SuiteSparse-$(LIBSUITESPARSE_VER)/build-checked: $(BUILDDIR)/SuiteSparse-$(LIBSUITESPARSE_VER)/build-compiled
7272
for PROJ in $(shell echo $(subst ;, ,$(LIBSUITESPARSE_PROJECTS))); do \
73-
$(LIBSUITESPARSE_SHLIB_ENV) $(CMAKE) --build $(dir $<)$${PROJ} default $(LIBSUITESPARSE_MFLAGS) || exit 1; \
73+
$(LIBSUITESPARSE_SHLIB_ENV) $(MAKE) -C $(dir $<)$${PROJ} default $(LIBSUITESPARSE_MFLAGS) || exit 1; \
7474
done
7575
echo 1 > $@
7676

deps/libtracyclient.mk

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,9 @@ $(LIBTRACYCLIENT_BUILDDIR)/build-configured: $(LIBTRACYCLIENT_BUILDDIR)/libTracy
5555

5656
$(LIBTRACYCLIENT_BUILDDIR)/build-compiled: $(LIBTRACYCLIENT_BUILDDIR)/build-configured
5757
cd $(LIBTRACYCLIENT_BUILDDIR) && \
58-
$(CMAKE) --build .
58+
$(if $(filter $(CMAKE_GENERATOR),make), \
59+
$(MAKE), \
60+
$(CMAKE) --build .)
5961
echo 1 > $@
6062

6163
$(eval $(call staged-install, \

deps/llvm.mk

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -270,7 +270,9 @@ $(LLVM_BUILDDIR_withtype)/build-configured: $(SRCCACHE)/$(LLVM_SRC_DIR)/source-e
270270

271271
$(LLVM_BUILDDIR_withtype)/build-compiled: $(LLVM_BUILDDIR_withtype)/build-configured
272272
cd $(LLVM_BUILDDIR_withtype) && \
273-
$(CMAKE) --build .
273+
$(if $(filter $(CMAKE_GENERATOR),make), \
274+
$(MAKE), \
275+
$(CMAKE) --build .)
274276
echo 1 > $@
275277

276278
$(LLVM_BUILDDIR_withtype)/build-checked: $(LLVM_BUILDDIR_withtype)/build-compiled

deps/mbedtls.mk

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,12 +39,12 @@ $(BUILDDIR)/$(MBEDTLS_SRC)/build-configured: $(SRCCACHE)/$(MBEDTLS_SRC)/source-e
3939
echo 1 > $@
4040

4141
$(BUILDDIR)/$(MBEDTLS_SRC)/build-compiled: $(BUILDDIR)/$(MBEDTLS_SRC)/build-configured
42-
$(CMAKE) --build $(dir $<)
42+
$(MAKE) -C $(dir $<)
4343
echo 1 > $@
4444

4545
$(BUILDDIR)/$(MBEDTLS_SRC)/build-checked: $(BUILDDIR)/$(MBEDTLS_SRC)/build-compiled
4646
ifeq ($(OS),$(BUILD_OS))
47-
$(CMAKE) --build $(dir $@) test
47+
$(MAKE) -C $(dir $@) test
4848
endif
4949
echo 1 > $@
5050

deps/unwind.mk

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,7 @@ $(BUILDDIR)/llvmunwind-$(LLVMUNWIND_VER)/build-configured: $(SRCCACHE)/llvmunwin
121121
echo 1 > $@
122122

123123
$(BUILDDIR)/llvmunwind-$(LLVMUNWIND_VER)/build-compiled: $(BUILDDIR)/llvmunwind-$(LLVMUNWIND_VER)/build-configured
124-
$(CMAKE) --build $(dir $<)
124+
$(MAKE) -C $(dir $<)
125125
echo 1 > $@
126126

127127
$(eval $(call staged-install, \

deps/zlib.mk

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ $(BUILDDIR)/$(ZLIB_SRC_DIR)/build-configured: $(SRCCACHE)/$(ZLIB_SRC_DIR)/source
1414
echo 1 > $@
1515

1616
$(BUILDDIR)/$(ZLIB_SRC_DIR)/build-compiled: $(BUILDDIR)/$(ZLIB_SRC_DIR)/build-configured
17-
$(CMAKE) --build $(dir $<)
17+
$(MAKE) -C $(dir $<) $(MAKE_COMMON)
1818
echo 1 > $@
1919

2020
$(eval $(call staged-install, \

0 commit comments

Comments
 (0)