Throw ArgumentError for negative array dimensions and added test (#32363)

Author: Nabanita Dash

src/array.c

@@ -64,7 +64,7 @@ static jl_array_t *_new_array_(jl_value_t *atype, uint32_t ndims, size_t *dims,
         size_t di = dims[i];
         wideint_t prod = (wideint_t)nel * (wideint_t)di;
         if (prod > (wideint_t) MAXINTVAL || di > MAXINTVAL)
-            jl_error("invalid Array dimensions");
+            jl_exceptionf(jl_argumenterror_type, "invalid Array dimensions");
         nel = prod;
     }
     assert(atype == NULL || isunion == jl_is_uniontype(jl_tparam0(atype)));
@@ -252,7 +252,7 @@ JL_DLLEXPORT jl_array_t *jl_reshape_array(jl_value_t *atype, jl_array_t *data,
             adims[i] = dims[i];
             prod = (wideint_t)l * (wideint_t)adims[i];
             if (prod > (wideint_t) MAXINTVAL)
-                jl_error("invalid Array dimensions");
+                jl_exceptionf(jl_argumenterror_type, "invalid Array dimensions");
             l = prod;
         }
 #ifdef STORE_ARRAY_LEN
@@ -356,7 +356,7 @@ JL_DLLEXPORT jl_array_t *jl_ptr_to_array(jl_value_t *atype, void *data,
     for (size_t i = 0; i < ndims; i++) {
         prod = (wideint_t)nel * (wideint_t)dims[i];
         if (prod > (wideint_t) MAXINTVAL)
-            jl_error("invalid Array dimensions");
+            jl_exceptionf(jl_argumenterror_type, "invalid Array dimensions");
         nel = prod;
     }
     if (__unlikely(ndims == 1))

stdlib/Random/test/runtests.jl

@@ -485,7 +485,7 @@ let mta = MersenneTwister(42), mtb = MersenneTwister(42)
     @test sort!(randperm(10)) == sort!(shuffle(1:10)) == 1:10
     @test randperm(mta,big(10)) == randperm(mtb,big(10)) # cf. #16376
     @test randperm(0) == []
-    @test_throws ErrorException randperm(-1)
+    @test_throws ArgumentError randperm(-1)
 
     let p = randperm(UInt16(12))
         @test typeof(p) ≡ Vector{UInt16}

test/arrayops.jl

@@ -2631,3 +2631,5 @@ end
 # Fix oneunit bug for unitful arrays
 @test oneunit([Second(1) Second(2); Second(3) Second(4)]) == [Second(1) Second(0); Second(0) Second(1)]
 
+# Throws ArgumentError for negative dimensions in Array
+@test_throws ArgumentError fill('a', -10)

test/core.jl

@@ -6841,9 +6841,9 @@ end
 @test repackage28445()
 
 # issue #28597
-@test_throws ErrorException Array{Int, 2}(undef, 0, -10)
-@test_throws ErrorException Array{Int, 2}(undef, -10, 0)
-@test_throws ErrorException Array{Int, 2}(undef, -1, -1)
+@test_throws ArgumentError Array{Int, 2}(undef, 0, -10)
+@test_throws ArgumentError Array{Int, 2}(undef, -10, 0)
+@test_throws ArgumentError Array{Int, 2}(undef, -1, -1)
 
 # issue #28812
 @test Tuple{Vararg{Array{T},3} where T} === Tuple{Array,Array,Array}