Skip to content

Commit 2984f9c

Browse files
committed
Couple of extra comments
1 parent 9f62658 commit 2984f9c

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

src/aotcompile.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2093,10 +2093,10 @@ void jl_get_llvmf_defn_impl(jl_llvmf_dump_t* dump, jl_method_instance_t *mi, siz
20932093
// // Force imaging mode for names of pointers
20942094
// output.imaging = true;
20952095
// This would also be nice, but it seems to cause OOMs on the windows32 builder
2096-
// // Force at least medium debug info for introspection
2096+
// Force at least medium debug info for introspection
20972097
// No debug info = no variable names,
20982098
// max debug info = llvm.dbg.declare/value intrinsics which clutter IR output
2099-
output.debug_level = jl_options.debug_level;
2099+
output.debug_level = std::max(1, static_cast<int>(jl_options.debug_level));
21002100
auto decls = jl_emit_code(m, mi, src, jlrettype, output);
21012101
JL_UNLOCK(&jl_codegen_lock); // Might GC
21022102

src/codegen.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7345,7 +7345,7 @@ static jl_llvm_functions_t
73457345
if (ctx.emission_context.debug_level > 0) {
73467346
auto arg_typename = [&](size_t i) JL_NOTSAFEPOINT {
73477347
auto tp = jl_tparam(lam->specTypes, i);
7348-
return jl_is_datatype(tp) ? jl_symbol_name(((jl_datatype_t*)tp)->name->name) : "<unknown datatype>";
7348+
return jl_is_datatype(tp) ? jl_symbol_name(((jl_datatype_t*)tp)->name->name) : "<unknown type>";
73497349
};
73507350
size_t nreal = 0;
73517351
for (size_t i = 0; i < std::min(nreq, static_cast<size_t>(used_args.size())); i++) {

0 commit comments

Comments
 (0)