enclose all existing tests within a new test set

Author: nsajko

test/no_invalidations.jl

@@ -51,42 +51,44 @@ function test_expr(f, supertype::Type)
 end
 
 @testset "no invalidations test set" begin
-    int_types = (Bool, Int8, UInt8, Int16, UInt16, Int, UInt, BigInt)
-    @testset "construction of old int type from new type" begin
-        broken = (Int8, UInt8, UInt16, Int, UInt)
-        @testset "T: $T" for T ∈ int_types
-            @test test_expr((n -> :(Base.$T(::$n) = $T(0))), Integer) broken=(T ∈ broken)
+    @testset "new subtype of `Integer`" begin
+        int_types = (Bool, Int8, UInt8, Int16, UInt16, Int, UInt, BigInt)
+        @testset "construction of old int type from new type" begin
+            broken = (Int8, UInt8, UInt16, Int, UInt)
+            @testset "T: $T" for T ∈ int_types
+                @test test_expr((n -> :(Base.$T(::$n) = $T(0))), Integer) broken=(T ∈ broken)
+            end
         end
-    end
-    @testset "construction of new int type from old type" begin
-        broken = ()
-        @testset "T: $T" for T ∈ int_types
-            @test test_expr((n -> :($n(::$T) = $n())), Integer) broken=(T ∈ broken)
+        @testset "construction of new int type from old type" begin
+            broken = ()
+            @testset "T: $T" for T ∈ int_types
+                @test test_expr((n -> :($n(::$T) = $n())), Integer) broken=(T ∈ broken)
+            end
         end
-    end
-    @testset "arithmetic between old int types and new int type" begin
-        ops = (:+, :*)
-        broken = ()
-        @testset "T: $T" for T ∈ int_types
-            @testset "op: $op" for op ∈ ops
+        @testset "arithmetic between old int types and new int type" begin
+            ops = (:+, :*)
+            broken = ()
+            @testset "T: $T" for T ∈ int_types
+                @testset "op: $op" for op ∈ ops
+                    @test (
+                        test_expr((n -> :(Base.$op(::$n, m::$T) = m)), Integer) &&
+                        test_expr((n -> :(Base.$op(m::$T, ::$n) = m)), Integer)
+                    ) broken=((T, op) ∈ broken)
+                end
+            end
+        end
+        @testset "promotion between old int types and new int type" begin
+            broken = (Bool, UInt8, Int)
+            @testset "T: $T" for T ∈ int_types
                 @test (
-                    test_expr((n -> :(Base.$op(::$n, m::$T) = m)), Integer) &&
-                    test_expr((n -> :(Base.$op(m::$T, ::$n) = m)), Integer)
-                ) broken=((T, op) ∈ broken)
+                    test_expr((n -> :(Base.promote_rule(::Type{$T}, ::Type{$n}) = $T)), Integer) &&
+                    test_expr((n -> :(Base.promote_rule(::Type{$n}, ::Type{$T}) = $T)), Integer)
+                ) broken=(T ∈ broken)
             end
         end
-    end
-    @testset "promotion between old int types and new int type" begin
-        broken = (Bool, UInt8, Int)
-        @testset "T: $T" for T ∈ int_types
-            @test (
-                test_expr((n -> :(Base.promote_rule(::Type{$T}, ::Type{$n}) = $T)), Integer) &&
-                test_expr((n -> :(Base.promote_rule(::Type{$n}, ::Type{$T}) = $T)), Integer)
-            ) broken=(T ∈ broken)
+        @testset "unary functions" begin
+            @test test_expr((n -> :(Base.zero(::$n) = $n())), Integer) broken=true
+            @test test_expr((n -> :(Base.one(::$n) = $n())), Integer) broken=true
         end
     end
-    @testset "unary functions" begin
-        @test test_expr((n -> :(Base.zero(::$n) = $n())), Integer) broken=true
-        @test test_expr((n -> :(Base.one(::$n) = $n())), Integer) broken=true
-    end
 end