Skip to content

Commit 55bdb54

Browse files
authored
Delete unnecessary methods in OffsetArrays.jl (#56564)
These are all defined elsewhere in Base: ```julia WARNING: Method definition fill(Any, Tuple{Vararg{Union{Integer, Base.AbstractUnitRange{T} where T}, N}}) where {N} in module Base at array.jl:542 overwritten in module OffsetArrays at /opt/hostedtoolcache/julia/nightly/x64/share/julia/test/testhelpers/OffsetArrays.jl:574. WARNING: Method definition zeros(Type{T}, Tuple{Vararg{Union{Integer, Base.AbstractUnitRange{T} where T}, N}}) where {T, N} in module Base at array.jl:603 overwritten in module OffsetArrays at /opt/hostedtoolcache/julia/nightly/x64/share/julia/test/testhelpers/OffsetArrays.jl:576. WARNING: Method definition ones(Type{T}, Tuple{Vararg{Union{Integer, Base.AbstractUnitRange{T} where T}, N}}) where {T, N} in module Base at array.jl:603 overwritten in module OffsetArrays at /opt/hostedtoolcache/julia/nightly/x64/share/julia/test/testhelpers/OffsetArrays.jl:578. WARNING: Method definition trues(Tuple{Vararg{Union{Integer, Base.AbstractUnitRange{T} where T}, N}}) where {N} in module Base at bitarray.jl:426 overwritten in module OffsetArrays at /opt/hostedtoolcache/julia/nightly/x64/share/julia/test/testhelpers/OffsetArrays.jl:580. WARNING: Method definition falses(Tuple{Vararg{Union{Integer, Base.AbstractUnitRange{T} where T}, N}}) where {N} in module Base at bitarray.jl:407 overwritten in module OffsetArrays at /opt/hostedtoolcache/julia/nightly/x64/share/julia/test/testhelpers/OffsetArrays.jl:582. ``` (similar to #56414)
1 parent e5f3010 commit 55bdb54

File tree

1 file changed

+0
-11
lines changed

1 file changed

+0
-11
lines changed

test/testhelpers/OffsetArrays.jl

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -571,17 +571,6 @@ Base.reshape(A::OffsetArray, inds::Tuple{Colon}) = _reshape_nov(A, inds)
571571
# This is a stopgap solution
572572
Base.permutedims(v::OffsetVector) = reshape(v, (1, axes(v, 1)))
573573

574-
Base.fill(v, inds::NTuple{N, Union{Integer, AbstractUnitRange}}) where {N} =
575-
fill!(similar(Array{typeof(v)}, inds), v)
576-
Base.zeros(::Type{T}, inds::NTuple{N, Union{Integer, AbstractUnitRange}}) where {T, N} =
577-
fill!(similar(Array{T}, inds), zero(T))
578-
Base.ones(::Type{T}, inds::NTuple{N, Union{Integer, AbstractUnitRange}}) where {T, N} =
579-
fill!(similar(Array{T}, inds), one(T))
580-
Base.trues(inds::NTuple{N, Union{Integer, AbstractUnitRange}}) where {N} =
581-
fill!(similar(BitArray, inds), true)
582-
Base.falses(inds::NTuple{N, Union{Integer, AbstractUnitRange}}) where {N} =
583-
fill!(similar(BitArray, inds), false)
584-
585574
Base.zero(A::OffsetArray) = parent_call(zero, A)
586575
Base.fill!(A::OffsetArray, x) = parent_call(Ap -> fill!(Ap, x), A)
587576

0 commit comments

Comments
 (0)