Skip to content

Commit 9373bd1

Browse files
authored
[test] precompile tests run on master 1, so may need explicit startup-file=no to pass (#59139)
Our Makefile passes this flag, which then propagates, and if any workers are launched, they have this flag set also, but when running tests manually via runtests.jl, it may not get set, causing some spurious failures here.
1 parent 884c5e3 commit 9373bd1

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

test/precompile.jl

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1884,8 +1884,8 @@ end
18841884

18851885
@testset "Precompile external abstract interpreter" begin
18861886
dir = @__DIR__
1887-
@test success(pipeline(Cmd(`$(Base.julia_cmd()) precompile_absint1.jl`; dir); stdout, stderr))
1888-
@test success(pipeline(Cmd(`$(Base.julia_cmd()) precompile_absint2.jl`; dir); stdout, stderr))
1887+
@test success(pipeline(Cmd(`$(Base.julia_cmd()) --startup-file=no precompile_absint1.jl`; dir); stdout, stderr))
1888+
@test success(pipeline(Cmd(`$(Base.julia_cmd()) --startup-file=no precompile_absint2.jl`; dir); stdout, stderr))
18891889
end
18901890

18911891
precompile_test_harness("Recursive types") do load_path
@@ -2420,7 +2420,7 @@ precompile_test_harness("llvmcall validation") do load_path
24202420
using LLVMCall
24212421
LLVMCall.do_llvmcall2()
24222422
"""
2423-
@test readchomp(`$(Base.julia_cmd()) --pkgimages=no -E $(testcode)`) == repr(UInt32(0))
2423+
@test readchomp(`$(Base.julia_cmd()) --startup-file=no --pkgimages=no -E $(testcode)`) == repr(UInt32(0))
24242424
# Now the regular way
24252425
@eval using LLVMCall
24262426
invokelatest() do
@@ -2500,7 +2500,7 @@ end
25002500

25012501
# Issue #58841 - make sure we don't accidentally throw away code for inference
25022502
let io = IOBuffer()
2503-
run(pipeline(`$(Base.julia_cmd()) --trace-compile=stderr -e 'f() = sin(1.) == 0. ? 1 : 0; exit(f())'`, stderr=io))
2503+
run(pipeline(`$(Base.julia_cmd()) --startup-file=no --trace-compile=stderr -e 'f() = sin(1.) == 0. ? 1 : 0; exit(f())'`, stderr=io))
25042504
@test isempty(String(take!(io)))
25052505
end
25062506

0 commit comments

Comments
 (0)