You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Keep expected crash in misc test from producing a core dump (#42990)
Currently the test in `test/misc.jl` that tests that a particular kind
of read fault crashes has two issues:
1. It works for the wrong reason. It's testing for `!success` when
evaluating code interpolated directly into the `Cmd`, but it isn't
quoting the code, so the subprocess fails with a syntax error instead
of the type of crash the test is expecting.
2. On some platforms (such as our good ol' pal FreeBSD), this kind of
read fault produces a core dump. This a bit annoying because it means
that the repo state becomes dirty after running the tests and it may
overwrite an existing core dump that was left behind by an earlier
issue we'd like to diagnose.
To fix these, we can wrap the code passed to the subprocess in single
quotes and on Unix-like systems wrap the subprocess in `ulimit -c 0` to
avoid producing a core dump.
(cherry picked from commit fa6dcb0)
0 commit comments