Don't delete inferred code from external interpreters (#57224)

gbaraldi · JeffBezanson · giordano · commit 9eaadcdbb3ea · 2025-02-01T19:37:20.000Z
We were deleting code from external abstract interpreters since bdf8219. Fixes JuliaGPU/CUDA.jl#2637. Not sure how to write tests for this :( --------- Co-authored-by: Jeff Bezanson <jeff.bezanson@gmail.com> (cherry picked from commit 832f084)
diff --git a/src/staticdata.c b/src/staticdata.c
@@ -859,6 +859,7 @@ static void jl_insert_into_serialization_queue(jl_serializer_state *s, jl_value_
                     record_field_change((jl_value_t**)&ci->inferred, jl_nothing);
                 }
                 else if (native_functions && // don't delete any code if making a ji file
+                         (ci->owner == jl_nothing) && // don't delete code for external interpreters
                          !effects_foldable(ci->ipo_purity_bits) && // don't delete code we may want for irinterp
                          jl_ir_inlining_cost(inferred) == UINT16_MAX) { // don't delete inlineable code
                     // delete the code now: if we thought it was worth keeping, it would have been converted to object code

Original file line number	Diff line number	Diff line change
`@@ -859,6 +859,7 @@ static void jl_insert_into_serialization_queue(jl_serializer_state *s, jl_value_`
`859`	`859`	`record_field_change((jl_value_t**)&ci->inferred, jl_nothing);`
`860`	`860`	`}`
`861`	`861`	`else if (native_functions && // don't delete any code if making a ji file`
	`862`	`+ (ci->owner == jl_nothing) && // don't delete code for external interpreters`
`862`	`863`	`!effects_foldable(ci->ipo_purity_bits) && // don't delete code we may want for irinterp`
`863`	`864`	`jl_ir_inlining_cost(inferred) == UINT16_MAX) { // don't delete inlineable code`
`864`	`865`	`// delete the code now: if we thought it was worth keeping, it would have been converted to object code`