trimming: make sure to fail / warn on Expr(:call, ...) (#57342)

topolarity · KristofferC · commit a1233eee2f7e · 2025-02-13T09:09:33.000+01:00
This dispatch should not be treated as resolved just because arg0 is constant. With the previous code, that meant it was eligible for last-minute call resolution, but call-resolution in codegen is now forbidden so this needs to fail unilaterally. (cherry picked from commit 0b74d17)
diff --git a/src/codegen.cpp b/src/codegen.cpp
@@ -5923,6 +5923,7 @@ static jl_cgval_t emit_call(jl_codectx_t &ctx, jl_expr_t *ex, jl_value_t *rt, bo
     if (ctx.params->trim != JL_TRIM_NO) {
         // TODO: Implement the last-minute call resolution that used to be here
         //       in inference instead.
+        failed_dispatch = 1;
     }
 
     if (failed_dispatch && trim_may_error(ctx.params->trim)) {

Original file line number	Diff line number	Diff line change
`@@ -5923,6 +5923,7 @@ static jl_cgval_t emit_call(jl_codectx_t &ctx, jl_expr_t ex, jl_value_t rt, bo`
`5923`	`5923`	`if (ctx.params->trim != JL_TRIM_NO) {`
`5924`	`5924`	`// TODO: Implement the last-minute call resolution that used to be here`
`5925`	`5925`	`// in inference instead.`
	`5926`	`+ failed_dispatch = 1;`
`5926`	`5927`	`}`
`5927`	`5928`
`5928`	`5929`	`if (failed_dispatch && trim_may_error(ctx.params->trim)) {`