do not bail when finding directories with matching name in dlload (#51295)

Author: KristofferC

src/dlload.c

@@ -367,8 +367,11 @@ JL_DLLEXPORT void *jl_load_dynamic_library(const char *modname, unsigned flags,
                     }
 #endif
                     // bail out and show the error if file actually exists
-                    if (jl_stat(path.buf, (char*)&stbuf) == 0)
-                        goto notfound;
+                    if (jl_stat(path.buf, (char *)&stbuf) == 0) {
+                        if (!S_ISDIR(stbuf.st_mode)) {
+                            goto notfound;
+                        }
+                    }
                 }
             }
         }
@@ -390,8 +393,11 @@ JL_DLLEXPORT void *jl_load_dynamic_library(const char *modname, unsigned flags,
         break; // LoadLibrary already tested the rest
 #else
         // bail out and show the error if file actually exists
-        if (jl_stat(path.buf, (char*)&stbuf) == 0)
-            break;
+        if (jl_stat(path.buf, (char *)&stbuf) == 0) {
+            if (!S_ISDIR(stbuf.st_mode)) {
+                break;
+            }
+        }
 #endif
     }
 

test/ccall.jl

@@ -2003,6 +2003,23 @@ end
     end
 end
 
+# issue #51293: Ensure we can load libraries even when a directory with the same name exists
+@testset "dlload with directory collision" begin
+    mktempdir() do dir
+        # Create a subdirectory with the same name as our test library
+        libdir = joinpath(dir, "libccalltest")
+        mkdir(libdir)
+
+        # Try to load libccalltest from within this directory
+        cd(dir) do
+            # This should successfully load the library from DL_LOAD_PATH, not fail due to the directory
+            hdl = Libdl.dlopen(libccalltest)
+            @test hdl != C_NULL
+            Libdl.dlclose(hdl)
+        end
+    end
+end
+
 module Test57749
 using Test, Zstd_jll
 const prefix = "Zstd version: "