Skip to content

Commit fa9478b

Browse files
mhauruinkydragon
andauthored
Fix regular expressions in Test tests (#57085)
Several tests for Test.jl weren't really testing for much because `|` characters were taken to be or operators in the regular expressions. Co-authored-by: Chengyu Han <[email protected]>
1 parent 1740287 commit fa9478b

File tree

1 file changed

+27
-27
lines changed

1 file changed

+27
-27
lines changed

stdlib/Test/test/runtests.jl

Lines changed: 27 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -870,12 +870,12 @@ let msg = read(pipeline(ignorestatus(`$(Base.julia_cmd()) --startup-file=no --co
870870
end
871871
end'`), stderr=devnull), String)
872872
@test occursin(r"""
873-
Test Summary: | Pass Fail Total Time
874-
Foo Tests | 2 2 4 \s*\d*.\ds
875-
Animals | 1 1 2 \s*\d*.\ds
876-
Felines | 1 1 \s*\d*.\ds
877-
Canines | 1 1 \s*\d*.\ds
878-
Arrays | 1 1 2 \s*\d*.\ds
873+
Test Summary: \| Pass Fail Total Time
874+
Foo Tests \| 2 2 4 \s*\d*\.\ds
875+
Animals \| 1 1 2 \s*\d*\.\ds
876+
Felines \| 1 1 \s*\d*\.\ds
877+
Canines \| 1 1 \s*\d*\.\ds
878+
Arrays \| 1 1 2 \s*\d*\.\ds
879879
""", msg)
880880
end
881881

@@ -1253,17 +1253,17 @@ end
12531253

12541254
@testset "verbose option" begin
12551255
expected = r"""
1256-
Test Summary: | Pass Total Time
1257-
Parent | 9 9 \s*\d*.\ds
1258-
Child 1 | 3 3 \s*\d*.\ds
1259-
Child 1.1 (long name) | 1 1 \s*\d*.\ds
1260-
Child 1.2 | 1 1 \s*\d*.\ds
1261-
Child 1.3 | 1 1 \s*\d*.\ds
1262-
Child 2 | 3 3 \s*\d*.\ds
1263-
Child 3 | 3 3 \s*\d*.\ds
1264-
Child 3.1 | 1 1 \s*\d*.\ds
1265-
Child 3.2 | 1 1 \s*\d*.\ds
1266-
Child 3.3 | 1 1 \s*\d*.\ds
1256+
Test Summary: \| Pass Total Time
1257+
Parent \| 9 9 \s*\d*\.\ds
1258+
Child 1 \| 3 3 \s*\d*\.\ds
1259+
Child 1\.1 \(long name\) \| 1 1 \s*\d*\.\ds
1260+
Child 1\.2 \| 1 1 \s*\d*\.\ds
1261+
Child 1\.3 \| 1 1 \s*\d*\.\ds
1262+
Child 2 \| 3 3 \s*\d*\.\ds
1263+
Child 3 \| 3 3 \s*\d*\.\ds
1264+
Child 3\.1 \| 1 1 \s*\d*\.\ds
1265+
Child 3\.2 \| 1 1 \s*\d*\.\ds
1266+
Child 3\.3 \| 1 1 \s*\d*\.\ds
12671267
"""
12681268

12691269
mktemp() do f, _
@@ -1324,9 +1324,9 @@ end
13241324
@testset "failfast option" begin
13251325
@testset "non failfast (default)" begin
13261326
expected = r"""
1327-
Test Summary: | Pass Fail Error Total Time
1328-
Foo | 1 2 1 4 \s*\d*.\ds
1329-
Bar | 1 1 2 \s*\d*.\ds
1327+
Test Summary: \| Pass Fail Error Total Time
1328+
Foo \| 1 2 1 4 \s*\d*\.\ds
1329+
Bar \| 1 1 2 \s*\d*\.\ds
13301330
"""
13311331

13321332
mktemp() do f, _
@@ -1350,8 +1350,8 @@ end
13501350
end
13511351
@testset "failfast" begin
13521352
expected = r"""
1353-
Test Summary: | Fail Total Time
1354-
Foo | 1 1 \s*\d*.\ds
1353+
Test Summary: \| Fail Total Time
1354+
Foo \| 1 1 \s*\d*\.\ds
13551355
"""
13561356

13571357
mktemp() do f, _
@@ -1375,9 +1375,9 @@ end
13751375
end
13761376
@testset "failfast passes to child testsets" begin
13771377
expected = r"""
1378-
Test Summary: | Fail Total Time
1379-
PackageName | 1 1 \s*\d*.\ds
1380-
1 | 1 1 \s*\d*.\ds
1378+
Test Summary: \| Fail Total Time
1379+
Foo \| 1 1 \s*\d*\.\ds
1380+
1 \| 1 1 \s*\d*\.\ds
13811381
"""
13821382

13831383
mktemp() do f, _
@@ -1401,8 +1401,8 @@ end
14011401
end
14021402
@testset "failfast via env var" begin
14031403
expected = r"""
1404-
Test Summary: | Fail Total Time
1405-
Foo | 1 1 \s*\d*.\ds
1404+
Test Summary: \| Fail Total Time
1405+
Foo \| 1 1 \s*\d*\.\ds
14061406
"""
14071407

14081408
mktemp() do f, _

0 commit comments

Comments
 (0)