Skip to content

Fix help when accessing fields of abstract types #60784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
PatrickHaecker wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix help when accessing fields of abstract types #60784

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions stdlib/REPL/src/docview.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -684,10 +684,16 @@ function fielddoc(binding::Binding, field::Symbol)
end
end
end
fs = fieldnames(resolve(binding))
fields = isempty(fs) ? "no fields" : (length(fs) == 1 ? "field " : "fields ") *
join(("`$f`" for f in fs), ", ", ", and ")
Markdown.parse("`$(resolve(binding))` has $fields.")
resolved = resolve(binding)
return if isabstracttype(resolved)
# Avoid calling `fieldnames`, as that would throw (#60783)
Markdown.parse("`$resolved` does not have fields as it is an abstract type.")
else
fs = fieldnames(resolved)
fields = isempty(fs) ? "no fields" : (length(fs) == 1 ? "field " : "fields ") *
join(("`$f`" for f in fs), ", ", ", and ")
Markdown.parse("`$resolved` has $fields.")
end
end

# As with the additional `doc` methods, this converts an object to a `Binding` first.
Expand Down