copy of subarray should call sub_materialize (#59)

* copy of subarray should call sub_materialize

* Update ArrayLayouts.jl

* test adjtrans copy

Author: dlfivefifty

Project.toml

@@ -1,7 +1,7 @@
 name = "ArrayLayouts"
 uuid = "4c555306-a7a7-4459-81d9-ec55ddd5c99a"
 authors = ["Sheehan Olver <[email protected]>"]
-version = "0.6.2"
+version = "0.6.3"
 
 [deps]
 FillArrays = "1a297f60-69ca-5386-bcde-b61e274b549b"

src/ArrayLayouts.jl

@@ -102,6 +102,9 @@ include("factorizations.jl")
 @inline sub_materialize(V::SubArray) = sub_materialize(MemoryLayout(V), V)
 @inline sub_materialize(V::AbstractArray) = V # Anything not a SubArray is already materialized
 
+copy(A::SubArray{<:Any,N,<:LayoutArray}) where N = sub_materialize(A)
+copy(A::SubArray{<:Any,N,<:AdjOrTrans{<:Any,<:LayoutArray}}) where N = sub_materialize(A)
+
 @inline layout_getindex(A, I...) = sub_materialize(view(A, I...))
 
 macro _layoutgetindex(Typ)

test/test_layoutarray.jl

@@ -1,4 +1,5 @@
 using ArrayLayouts, LinearAlgebra, Test
+import ArrayLayouts: sub_materialize
 
 struct MyMatrix <: LayoutMatrix{Float64}
     A::Matrix{Float64}
@@ -42,8 +43,12 @@ MemoryLayout(::Type{MyVector}) = DenseColumnMajor()
 
         @test a'a == transpose(a)a == dot(a,a) == dot(a,a.A) == dot(a.A,a) == 14
         v = view(a,1:3)
+        @test copy(v) == sub_materialize(v) == a[1:3]
         @test dot(v,a) == dot(v,a.A) == dot(a,v) == dot(a.A,v) == dot(v,v) == 14
 
+        V = view(a',:,1:3)
+        @test copy(V) == sub_materialize(V) == (a')[:,1:3]
+
         s = SparseVector(3, [1], [2])
         @test a's == s'a == dot(a,s) == dot(s,a) == dot(s,a.A)
     end