Skip to content

Commit 74af367

Browse files
jishnubjishnub
authored
replace elementwise equality by array equality in tests (#190)
1 parent ae6c9cd commit 74af367

File tree

3 files changed

+207
-207
lines changed

3 files changed

+207
-207
lines changed

‎test/test_layoutarray.jl

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -99,10 +99,10 @@ MemoryLayout(::Type{MyVector}) = DenseColumnMajor()
9999
@test_throws ErrorException qr!(A)
100100
@test lu!(copy(A)).factors ≈ lu(A.A).factors
101101
b = randn(5)
102-
@test all(A \ b .≡ A.A \ b .≡ A.A \ MyVector(b) .≡ ldiv!(lu(A.A), copy(MyVector(b))))
103-
@test all(A \ b .≡ ldiv!(lu(A), copy(MyVector(b))) .≡ ldiv!(lu(A), copy(b)))
104-
@test all(lu(A).L .≡ lu(A.A).L)
105-
@test all(lu(A).U .≡ lu(A.A).U)
102+
@test A \ b == A.A \ b == A.A \ MyVector(b) == ldiv!(lu(A.A), copy(MyVector(b)))
103+
@test A \ b == ldiv!(lu(A), copy(MyVector(b))) == ldiv!(lu(A), copy(b))
104+
@test lu(A).L == lu(A.A).L
105+
@test lu(A).U == lu(A.A).U
106106
@test lu(A).p == lu(A.A).p
107107
@test lu(A).P == lu(A.A).P
108108

@@ -166,7 +166,7 @@ MemoryLayout(::Type{MyVector}) = DenseColumnMajor()
166166
Bin = randn(5,5)
167167
B = MyMatrix(copy(Bin))
168168
muladd!(1.0, A, A, 2.0, B)
169-
@test all(B .=== A.A^2 + 2Bin)
169+
@test B == A.A^2 + 2Bin
170170

171171
@testset "tiled_blasmul!" begin
172172
B = MyMatrix(copy(Bin))

‎test/test_ldiv.jl

Lines changed: 45 additions & 45 deletions
Original file line numberDiff line numberDiff line change
@@ -15,49 +15,49 @@ import ArrayLayouts: ApplyBroadcastStyle, QRCompactWYQLayout, QRCompactWYLayout,
1515
@test size(M) == (5,)
1616
@test similar(M) isa Vector{Float64}
1717
@test materialize(M) isa Vector{Float64}
18-
@test all(materialize(M) .=== (A\b) .=== ldiv(A,b))
18+
@test materialize(M) == (A\b) == ldiv(A,b)
1919

2020
@test Base.BroadcastStyle(typeof(Ldiv(A,b))) isa ApplyBroadcastStyle
2121

22-
@test all(copyto!(similar(b), Ldiv(A,b)) .===
23-
(similar(b) .= Ldiv(A,b)) .=== materialize(Ldiv(A,b)) .===
24-
(A\b) .=== (b̃ = copy(b); LAPACK.gesv!(copy(A), b̃); b̃))
22+
@test copyto!(similar(b), Ldiv(A,b)) ==
23+
(similar(b) .= Ldiv(A,b)) == materialize(Ldiv(A,b)) ==
24+
(A\b) == (b̃ = copy(b); LAPACK.gesv!(copy(A), b̃); b̃)
2525

2626
@test copyto!(similar(b), Ldiv(UpperTriangular(A) , b)) ≈ UpperTriangular(A) \ b
27-
@test all(copyto!(similar(b), Ldiv(UpperTriangular(A) , b)) .===
28-
(similar(b) .= Ldiv(UpperTriangular(A),b)) .===
29-
BLAS.trsv('U', 'N', 'N', A, b) )
27+
@test copyto!(similar(b), Ldiv(UpperTriangular(A) , b)) ==
28+
(similar(b) .= Ldiv(UpperTriangular(A),b)) ==
29+
BLAS.trsv('U', 'N', 'N', A, b)
3030

3131
@test copyto!(similar(b), Ldiv(UpperTriangular(A)' , b)) ≈ UpperTriangular(A)' \ b
32-
@test all(copyto!(similar(b), Ldiv(UpperTriangular(A)' , b)) .===
33-
(similar(b) .= Ldiv(UpperTriangular(A)',b)) .===
34-
copyto!(similar(b), Ldiv(transpose(UpperTriangular(A)) , b)) .===
35-
(similar(b) .= Ldiv(transpose(UpperTriangular(A)),b)) .===
36-
BLAS.trsv('U', 'T', 'N', A, b))
32+
@test copyto!(similar(b), Ldiv(UpperTriangular(A)' , b)) ==
33+
(similar(b) .= Ldiv(UpperTriangular(A)',b)) ==
34+
copyto!(similar(b), Ldiv(transpose(UpperTriangular(A)) , b)) ==
35+
(similar(b) .= Ldiv(transpose(UpperTriangular(A)),b)) ==
36+
BLAS.trsv('U', 'T', 'N', A, b)
3737
end
3838

3939
@testset "ComplexF64 \\ *" begin
4040
T = ComplexF64
4141
A = randn(T,5,5)
4242
b = randn(T,5)
43-
@test all(copyto!(similar(b), Ldiv(A,b)) .===
44-
(similar(b) .= Ldiv(A,b)) .===
45-
(A\b) .=== (b̃ = copy(b); LAPACK.gesv!(copy(A), b̃); b̃))
43+
@test copyto!(similar(b), Ldiv(A,b)) ==
44+
(similar(b) .= Ldiv(A,b)) ==
45+
(A\b) == (b̃ = copy(b); LAPACK.gesv!(copy(A), b̃); b̃)
4646

4747
@test copyto!(similar(b), Ldiv(UpperTriangular(A) , b)) ≈ UpperTriangular(A) \ b
48-
@test all(copyto!(similar(b), Ldiv(UpperTriangular(A) , b)) .===
49-
(similar(b) .= Ldiv(UpperTriangular(A),b)) .===
50-
BLAS.trsv('U', 'N', 'N', A, b) )
48+
@test copyto!(similar(b), Ldiv(UpperTriangular(A) , b)) ==
49+
(similar(b) .= Ldiv(UpperTriangular(A),b)) ==
50+
BLAS.trsv('U', 'N', 'N', A, b)
5151

5252
@test copyto!(similar(b), Ldiv(UpperTriangular(A)' , b)) ≈ UpperTriangular(A)' \ b
53-
@test all(copyto!(similar(b), Ldiv(UpperTriangular(A)' , b)) .===
54-
(similar(b) .= Ldiv(UpperTriangular(A)',b)) .===
55-
BLAS.trsv('U', 'C', 'N', A, b))
53+
@test copyto!(similar(b), Ldiv(UpperTriangular(A)' , b)) ==
54+
(similar(b) .= Ldiv(UpperTriangular(A)',b)) ==
55+
BLAS.trsv('U', 'C', 'N', A, b)
5656

5757
@test copyto!(similar(b), Ldiv(transpose(UpperTriangular(A)) , b)) ≈ transpose(UpperTriangular(A)) \ b
58-
@test all(copyto!(similar(b), Ldiv(transpose(UpperTriangular(A)) , b)) .===
59-
(similar(b) .= Ldiv(transpose(UpperTriangular(A)),b)) .===
60-
BLAS.trsv('U', 'T', 'N', A, b))
58+
@test copyto!(similar(b), Ldiv(transpose(UpperTriangular(A)) , b)) ==
59+
(similar(b) .= Ldiv(transpose(UpperTriangular(A)),b)) ==
60+
BLAS.trsv('U', 'T', 'N', A, b)
6161
end
6262

6363
@testset "BigFloat Triangular \\" begin
@@ -152,12 +152,12 @@ import ArrayLayouts: ApplyBroadcastStyle, QRCompactWYQLayout, QRCompactWYLayout,
152152
Q = F.Q
153153
@test MemoryLayout(F) isa QRCompactWYLayout
154154
@test MemoryLayout(Q) isa QRCompactWYQLayout
155-
@test all(ArrayLayouts.lmul!(Q,copy(b)) .=== lmul!(Q,copy(b)))
156-
@test all(ArrayLayouts.lmul!(Q',copy(b)) .=== ArrayLayouts.ldiv!(Q,copy(b)) .=== lmul!(Q',copy(b)))
157-
@test all(ArrayLayouts.lmul!(Q,copy(B)) .=== lmul!(Q,copy(B)))
158-
@test all(ArrayLayouts.lmul!(Q',copy(B)) .=== ArrayLayouts.ldiv!(Q,copy(B)) .=== lmul!(Q',copy(B)))
159-
@test all(ArrayLayouts.rmul!(copy(B),Q) .=== rmul!(copy(B),Q))
160-
@test all(ArrayLayouts.rmul!(copy(B),Q') .=== ArrayLayouts.rdiv!(copy(B),Q) .=== rmul!(copy(B),Q'))
155+
@test ArrayLayouts.lmul!(Q,copy(b)) == lmul!(Q,copy(b))
156+
@test ArrayLayouts.lmul!(Q',copy(b)) == ArrayLayouts.ldiv!(Q,copy(b)) == lmul!(Q',copy(b))
157+
@test ArrayLayouts.lmul!(Q,copy(B)) == lmul!(Q,copy(B))
158+
@test ArrayLayouts.lmul!(Q',copy(B)) == ArrayLayouts.ldiv!(Q,copy(B)) == lmul!(Q',copy(B))
159+
@test ArrayLayouts.rmul!(copy(B),Q) == rmul!(copy(B),Q)
160+
@test ArrayLayouts.rmul!(copy(B),Q') == ArrayLayouts.rdiv!(copy(B),Q) == rmul!(copy(B),Q')
161161
@test ArrayLayouts.ldiv!(F,copy(b)) ≈ ldiv!(F,copy(b)) # only approx since we use BLAS.trsv!
162162
@test ArrayLayouts.ldiv!(F,copy(B)) ≈ ldiv!(F,copy(B)) # only approx since we use BLAS.trsv!
163163

@@ -176,11 +176,11 @@ import ArrayLayouts: ApplyBroadcastStyle, QRCompactWYQLayout, QRCompactWYLayout,
176176
Q = F.Q
177177
@test MemoryLayout(F) isa QRPackedLayout
178178
@test MemoryLayout(Q) isa QRPackedQLayout
179-
@test all(ArrayLayouts.lmul!(Q,copy(b)) .=== lmul!(Q,copy(b)))
180-
@test all(ArrayLayouts.lmul!(Q',copy(b)) .=== ArrayLayouts.ldiv!(Q,copy(b)) .=== lmul!(Q',copy(b)))
181-
@test all(ArrayLayouts.lmul!(Q,copy(B)) .=== lmul!(Q,copy(B)))
182-
@test all(ArrayLayouts.lmul!(Q',copy(B)) .=== ArrayLayouts.ldiv!(Q,copy(B)) .=== lmul!(Q',copy(B)))
183-
@test all(ArrayLayouts.rmul!(copy(B),Q) .=== rmul!(copy(B),Q))
179+
@test ArrayLayouts.lmul!(Q,copy(b)) == lmul!(Q,copy(b))
180+
@test ArrayLayouts.lmul!(Q',copy(b)) == ArrayLayouts.ldiv!(Q,copy(b)) == lmul!(Q',copy(b))
181+
@test ArrayLayouts.lmul!(Q,copy(B)) == lmul!(Q,copy(B))
182+
@test ArrayLayouts.lmul!(Q',copy(B)) == ArrayLayouts.ldiv!(Q,copy(B)) == lmul!(Q',copy(B))
183+
@test ArrayLayouts.rmul!(copy(B),Q) == rmul!(copy(B),Q)
184184
@test ArrayLayouts.rmul!(copy(B),Q') ≈ ArrayLayouts.rdiv!(copy(B),Q) ≈ rmul!(copy(B),Q')
185185
@test ArrayLayouts.ldiv!(F,copy(b)) ≈ ldiv!(F,copy(b)) # only approx since we use BLAS.trsv!
186186
@test ArrayLayouts.ldiv!(F,copy(B)) ≈ ldiv!(F,copy(B)) # only approx since we use BLAS.trsv!
@@ -216,11 +216,11 @@ import ArrayLayouts: ApplyBroadcastStyle, QRCompactWYQLayout, QRCompactWYLayout,
216216
B = T.(randn(12,12))
217217
F = LinearAlgebra.qrfactUnblocked!(copy(A))
218218
Q = F.Q
219-
@test all(ArrayLayouts.lmul!(Q,copy(b)) == lmul!(Q,copy(b)))
220-
@test all(ArrayLayouts.lmul!(Q',copy(b)) == ArrayLayouts.ldiv!(Q,copy(b)) == lmul!(Q',copy(b)))
221-
@test all(ArrayLayouts.lmul!(Q,copy(B)) == lmul!(Q,copy(B)))
222-
@test all(ArrayLayouts.lmul!(Q',copy(B)) == ArrayLayouts.ldiv!(Q,copy(B)) == lmul!(Q',copy(B)))
223-
@test all(ArrayLayouts.rmul!(copy(B),Q) == rmul!(copy(B),Q))
219+
@test ArrayLayouts.lmul!(Q,copy(b)) == lmul!(Q,copy(b))
220+
@test ArrayLayouts.lmul!(Q',copy(b)) == ArrayLayouts.ldiv!(Q,copy(b)) == lmul!(Q',copy(b))
221+
@test ArrayLayouts.lmul!(Q,copy(B)) == lmul!(Q,copy(B))
222+
@test ArrayLayouts.lmul!(Q',copy(B)) == ArrayLayouts.ldiv!(Q,copy(B)) == lmul!(Q',copy(B))
223+
@test ArrayLayouts.rmul!(copy(B),Q) == rmul!(copy(B),Q)
224224
@test ArrayLayouts.rmul!(copy(B),Q') ≈ ArrayLayouts.rdiv!(copy(B),Q) ≈ rmul!(copy(B),Q')
225225
@test ArrayLayouts.ldiv!(F,copy(b)) ≈ ldiv!(F,copy(b)) # only approx since we use BLAS.trsv!
226226
@test ArrayLayouts.ldiv!(F,copy(B)) ≈ ldiv!(F,copy(B)) # only approx since we use BLAS.trsv!
@@ -232,11 +232,11 @@ import ArrayLayouts: ApplyBroadcastStyle, QRCompactWYQLayout, QRCompactWYLayout,
232232
B = T.(randn(10,10))
233233
F = LinearAlgebra.qrfactUnblocked!(copy(A))
234234
Q = F.Q
235-
@test all(ArrayLayouts.lmul!(Q,copy(b)) == lmul!(Q,copy(b)))
236-
@test all(ArrayLayouts.lmul!(Q',copy(b)) == ArrayLayouts.ldiv!(Q,copy(b)) == lmul!(Q',copy(b)))
237-
@test all(ArrayLayouts.lmul!(Q,copy(B)) == lmul!(Q,copy(B)))
238-
@test all(ArrayLayouts.lmul!(Q',copy(B)) == ArrayLayouts.ldiv!(Q,copy(B)) == lmul!(Q',copy(B)))
239-
@test all(ArrayLayouts.rmul!(copy(B),Q) == rmul!(copy(B),Q))
235+
@test ArrayLayouts.lmul!(Q,copy(b)) == lmul!(Q,copy(b))
236+
@test ArrayLayouts.lmul!(Q',copy(b)) == ArrayLayouts.ldiv!(Q,copy(b)) == lmul!(Q',copy(b))
237+
@test ArrayLayouts.lmul!(Q,copy(B)) == lmul!(Q,copy(B))
238+
@test ArrayLayouts.lmul!(Q',copy(B)) == ArrayLayouts.ldiv!(Q,copy(B)) == lmul!(Q',copy(B))
239+
@test ArrayLayouts.rmul!(copy(B),Q) == rmul!(copy(B),Q)
240240
@test ArrayLayouts.rmul!(copy(B),Q') ≈ ArrayLayouts.rdiv!(copy(B),Q) ≈ rmul!(copy(B),Q')
241241

242242
@test_throws DimensionMismatch ArrayLayouts.ldiv!(F,copy(b))

0 commit comments

Comments
 (0)