Revert "Use map! in broadcasting if sizes match (#284)"

This reverts commit e9f7266.

Author: dlfivefifty

src/generic/broadcast.jl

@@ -643,9 +643,7 @@ function _banded_broadcast!(dest::AbstractMatrix, f, (A,B)::Tuple{AbstractMatrix
     data_d,data_A, data_B = bandeddata(dest), bandeddata(A), bandeddata(B)
 
     if (d_l,d_u) == (A_l,A_u) == (B_l,B_u)
-        # An inplace map is faster than an inplace broadcast
-        # (checked on Julia v1.8.3 and 1.10 dev)
-        map!(f, data_d, data_A, data_B)
+        data_d .= f.(data_A,data_B)
     else
         max_l,max_u = max(A_l,B_l,d_l),max(A_u,B_u,d_u)
         min_l,min_u = min(A_l,B_l,d_l),min(A_u,B_u,d_u)

test/test_broadcasting.jl

@@ -37,8 +37,6 @@ import BandedMatrices: BandedStyle, BandedRows
         @test 1 .+ A isa BandedMatrix
         @test (1 .+ A) == 1 .+ Matrix(A)
 
-        @test A .+ A == 2A
-
         @test 1 .\ A == 1 .\ Matrix(A)
         @test 1 .\ A isa BandedMatrix
         @test bandwidths(1 .\ A) == bandwidths(A)