Use a copyto! approach in _BandedMatrix(::BandedRows, A), and switch to PermutedDimsArray in bandedrowsdata #488
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This switches from a loop approach over each axis to an approach that instead uses
copyto!over each of the diagonal components. Moreover, I switch toPermutedDimsArrayinstead ofpermutedimsin thebandedrowsdataimplementation sincepermutedimsallocates an entire new matrix whilePermutedDimsArrayis lazy (see, e.g.)
(I see there are some overloads in
src/bandedthat try and makepermutedimslazy for certain types, but for the matrices I was dealing with these overloads were not reaching it. This seemed like a simpler fix for the time being, since I think an alternative requires piracy for my matrices.)