Skip to content

Commit 8b08068

Browse files
committed
Minor fixes for Julia 1.0
1 parent 415e805 commit 8b08068

File tree

4 files changed

+11
-4
lines changed

4 files changed

+11
-4
lines changed

.travis.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ os:
55

66
julia:
77
- 0.7
8+
- 1.0
89
- nightly
910

1011
matrix:

REQUIRE

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
julia 0.7-beta
1+
julia 0.7

src/eigenSelfAdjoint.jl

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,13 @@ struct EigenQ{T} <: AbstractMatrix{T}
1717
τ::Vector{T}
1818
end
1919

20-
LinearAlgebra.getq(S::SymmetricTridiagonalFactorization) = EigenQ(S.uplo, S.factors, S.τ)
20+
function Base.getproperty(S::SymmetricTridiagonalFactorization, s::Symbol)
21+
if s == :Q
22+
return EigenQ(S.uplo, S.factors, S.τ)
23+
else
24+
throw(ArgumentError("no property $s"))
25+
end
26+
end
2127

2228
Base.size(Q::EigenQ) = (size(Q.factors, 1), size(Q.factors, 1))
2329
function Base.size(Q::EigenQ, i::Integer)
@@ -543,7 +549,7 @@ function eigen2!(A::SymmetricTridiagonalFactorization, tol = eps(real(float(one(
543549
V = zeros(eltype(A), 2, size(A, 1))
544550
V[1] = 1
545551
V[end] = 1
546-
eigQL!(A.diagonals, rmul!(V, getq(A)), tol, debug)
552+
eigQL!(A.diagonals, rmul!(V, A.Q), tol, debug)
547553
end
548554
function eigen2!(A::SymTridiagonal, tol = eps(real(float(one(eltype(A))))), debug = false)
549555
V = zeros(eltype(A), 2, size(A, 1))

src/svd.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -255,7 +255,7 @@ function bidiagonalize!(A::AbstractMatrix)
255255
end
256256
end
257257

258-
_svdvals!(A::StridedMatrix; tol = eps(T), debug = false) = svdvals!(bidiagonalize!(A)[1], tol = tol, debug = debug)
258+
_svdvals!(A::StridedMatrix; tol = eps(real(eltype(A))), debug = false) = svdvals!(bidiagonalize!(A)[1], tol = tol, debug = debug)
259259

260260
LinearAlgebra.svdvals!(B::Bidiagonal{T}; tol = eps(T), debug = false) where T<:Real = _svdvals!(B, tol = tol, debug = debug)
261261
LinearAlgebra.svdvals!(A::StridedMatrix; tol = eps(real(eltype(A))), debug = false) = _svdvals!(A, tol = tol, debug = debug)

0 commit comments

Comments
 (0)