Skip to content

Commit fc66e40

Browse files
committed
Prepare for Julia 1.3
1 parent ca2a03b commit fc66e40

File tree

1 file changed

+12
-2
lines changed

1 file changed

+12
-2
lines changed

src/svd.jl

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -280,13 +280,23 @@ function Base.getproperty(F::BidiagonalFactorization, s::Symbol)
280280
if s === :leftQ
281281
return LinearAlgebra.QRPackedQ(R, τl)
282282
elseif s === :rightQ
283-
return LinearAlgebra.HessenbergQ(copy(transpose(R[1:size(R,2),:])), τr)
283+
if VERSION < v"1.3.0-DEV.243"
284+
return LinearAlgebra.HessenbergQ(copy(transpose(R[1:size(R,2),:])), τr)
285+
else
286+
factors = copy(transpose(R[1:size(R,2),:]))
287+
return LinearAlgebra.HessenbergQ{eltype(factors),typeof(factors),typeof(τr),false}('U', factors, τr)
288+
end
284289
else
285290
return getfield(F, s)
286291
end
287292
else
288293
if s === :leftQ
289-
return LinearAlgebra.HessenbergQ(R[:,1:size(R,1)], τl)
294+
if VERSION < v"1.3.0-DEV.243"
295+
return LinearAlgebra.HessenbergQ(R[:,1:size(R,1)], τl)
296+
else
297+
factors = R[:,1:size(R,1)]
298+
return LinearAlgebra.HessenbergQ{eltype(factors),typeof(factors),typeof(τr),false}('U', factors, τl)
299+
end
290300
elseif s === :rightQ
291301
# return transpose(LinearAlgebra.LQPackedQ(R, τr)) # FixMe! check that this shouldn't be adjoint
292302
LinearAlgebra.QRPackedQ(copy(transpose(R)), τr)

0 commit comments

Comments
 (0)