Skip to content
This repository was archived by the owner on Apr 26, 2021. It is now read-only.

Commit 07156af

Browse files
authored
fix on 1.3 and add Project file (#19)
* fix on 1.3 and add Project file * Update GenericSVD.jl * Update Project.toml
1 parent a271fdd commit 07156af

File tree

5 files changed

+26
-11
lines changed

5 files changed

+26
-11
lines changed

.travis.yml

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -4,15 +4,10 @@ os:
44
- linux
55
- osx
66
julia:
7-
- 0.7
87
- 1.0
8+
- 1.2
99
- nightly
1010
notifications:
1111
email: false
12-
13-
script:
14-
- if [[ -a .git/shallow ]]; then git fetch --unshallow; fi
15-
- julia --color=yes -e 'using InteractiveUtils; versioninfo(); import Pkg; Pkg.clone(pwd()); Pkg.build("GenericSVD")'
16-
- julia --color=yes --check-bounds=yes -e 'import Pkg; Pkg.test("GenericSVD"; coverage=true)'
1712
after_success:
18-
- julia -e 'import Pkg; cd(Pkg.dir("GenericSVD")); Pkg.add("Coverage"); using Coverage; Coveralls.submit(process_folder()); Codecov.submit(process_folder())'
13+
- julia --project -e 'import Pkg; Pkg.add("Coverage"); using Coverage; Coveralls.submit(process_folder()); Codecov.submit(process_folder())'

Project.toml

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
name = "GenericSVD"
2+
uuid = "01680d73-4ee2-5a08-a1aa-533608c188bb"
3+
version = "0.2.2"
4+
5+
[deps]
6+
LinearAlgebra = "37e2e46d-f89d-539d-b4ee-838fcccc9c8e"
7+
8+
[compat]
9+
julia = "1.0"
10+
11+
[extras]
12+
LinearAlgebra = "37e2e46d-f89d-539d-b4ee-838fcccc9c8e"
13+
Quaternions = "94ee1d12-ae83-5a48-8b1c-48b8ff168ae0"
14+
Random = "9a3f8284-a2c9-5f02-9a11-845980a1fd5c"
15+
Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"
16+
17+
[targets]
18+
test = ["LinearAlgebra", "Test", "Random", "Quaternions"]

REQUIRE

Lines changed: 0 additions & 1 deletion
This file was deleted.

appveyor.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
environment:
22
matrix:
3-
- julia_version: 0.7
43
- julia_version: 1.0
4+
- julia_version: 1.2
55
- julia_version: latest
66

77
platform:

src/GenericSVD.jl

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,12 @@ import LinearAlgebra: SVD, svd!
77
include("utils.jl")
88
include("bidiagonalize.jl")
99

10-
function svd!(X::AbstractMatrix; full::Bool=false, thin::Union{Bool,Nothing} = nothing)
10+
function svd!(X::AbstractMatrix; full::Bool=false, thin::Union{Bool,Nothing} = nothing, alg=nothing)
11+
if alg != nothing
12+
@warn "keyword `alg` ignored in generic svd!"
13+
end
1114
if thin != nothing
12-
@warn "obsolete keyword thin in generic svd!"
15+
@warn "obsolete keyword `thin` in generic svd!"
1316
thinx = thin
1417
else
1518
thinx = !full

0 commit comments

Comments
 (0)