remove compat for 0.5, use view macro

Author: simonbyrne

REQUIRE

@@ -1,2 +1 @@
-julia 0.4
-Compat 0.8.6
+julia 0.5

src/bidiagonalize.jl

@@ -1,12 +1,18 @@
 """
-Packed storage of bidiagonalizing QR reflectors.
+    PackedUVt <: Factorization{T}
+
+Packed storage of bidiagonalizing QR reflectors `U` and `V'`.
+
+
 """
-immutable PackedUVt{T}
+immutable PackedUVt{T} <: Factorization{T}
     A::Matrix{T}
 end
 
 
 """
+    bidiagonalize_tall!{T}(A::Matrix{T},B::Bidiagonal)
+
 Bidiagonalize a tall matrix `A` into `B`. Both arguments are overwritten.
 """
 function bidiagonalize_tall!{T}(A::Matrix{T},B::Bidiagonal)
@@ -15,20 +21,20 @@ function bidiagonalize_tall!{T}(A::Matrix{T},B::Bidiagonal)
     # upper bidiagonal
 
     for i = 1:n
-        x = view(A, i:m, i)
+        x = @view A[i:m, i]
         τi = LinAlg.reflector!(x)
         B.dv[i] = real(A[i,i])
-        LinAlg.reflectorApply!(x, τi, view(A, i:m, i+1:n))
-        A[i,i] = τi # store reflector in diagonal coefficient
+        LinAlg.reflectorApply!(x, τi, @view(A[i:m, i+1:n]))
+        A[i,i] = τi # store reflector coefficient in diagonal
 
         # for Real, this only needs to be n-2
         # needed for Complex to ensure superdiagonal is Real
         if i <= n-1
-            x = view(A, i, i+1:n)
+            x = @view A[i, i+1:n]
             conj!(x)
             τi = LinAlg.reflector!(x)
             B.ev[i] = real(A[i,i+1])
-            LinAlg.reflectorApply!(view(A, i+1:m, i+1:n), x, τi)
+            LinAlg.reflectorApply!(@view(A[i+1:m, i+1:n]), x, τi)
             A[i,i+1] = τi
         end
     end
@@ -53,16 +59,16 @@ function Base.full{T}(P::PackedUVt{T};thin=true)
     U = eye(T,m,w)
     for i = n:-1:1
         τi = A[i,i]
-        x = view(A, i:m, i)
-        LinAlg.reflectorApply!(x, τi', view(U, i:m, i:w))
+        x = @view A[i:m, i]
+        LinAlg.reflectorApply!(x, τi', @view(U[i:m, i:w]))
     end
 
     # Vt = P_{n_2} ... P_1
     Vt = eye(T,n,n)
     for i = n-1:-1:1
         τi = A[i,i+1]
-        x = view(A, i, i+1:n)
-        LinAlg.reflectorApply!(view(Vt, i:n, i+1:n), x, τi')
+        x = @view A[i, i+1:n]
+        LinAlg.reflectorApply!(@view(Vt[i:n, i+1:n]), x, τi')
     end
     U,Vt
 end

src/utils.jl

@@ -25,24 +25,3 @@ import Base: A_mul_B!, A_mul_Bc!, A_ldiv_B!
 
 A_mul_B!(G::LinAlg.Givens, ::Void) = nothing
 A_mul_Bc!(::Void, G::LinAlg.Givens) = nothing
-
-if VERSION < v"0.5.0-"
-    function A_ldiv_B!{Ta,Tb}(A::SVD{Ta}, B::StridedVecOrMat{Tb})
-        k = searchsortedlast(A.S, eps(real(Ta))*A.S[1], rev=true)
-        view(A.Vt,1:k,:)' * (view(A.S,1:k) .\ (view(A.U,:,1:k)' * B))
-    end
-end
-
-
-# we have to define our own givens function due to ordering restriction in Base (#14936)
-function givens{T}(f::T, g::T, i1::Integer, i2::Integer)
-    if i1 == i2
-        throw(ArgumentError("Indices must be distinct."))
-    end
-    c, s, r = Base.LinAlg.givensAlgorithm(f, g)
-    if i1 > i2
-        s = -conj(s)
-        i1,i2 = i2,i1
-    end
-    Base.LinAlg.Givens(i1, i2, convert(T, c), convert(T, s)), r
-end