Skip to content
This repository was archived by the owner on Apr 26, 2021. It is now read-only.

Commit d89e7ea

Browse files
committed
create intermedite functions
1 parent 5d5fff2 commit d89e7ea

File tree

1 file changed

+6
-3
lines changed

1 file changed

+6
-3
lines changed

src/GenericSVD.jl

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,14 @@
11
module GenericSVD
22

3-
import Base: SVD, svdvals!, svdfact!
3+
import Base: SVD
44

55
include("utils.jl")
66
include("bidiagonalize.jl")
77

8-
function svdfact!(X; sorted=true, thin=true)
8+
Base.svdfact!(X::AbstractMatrix; thin=true) = generic_svdfact!(X; thin=thin)
9+
Base.svdvals!(X::AbstractMatrix) = generic_svdvals!(X)
10+
11+
function generic_svdfact!(X::AbstractMatrix; sorted=true, thin=true)
912
m,n = size(X)
1013
t =false
1114
if m < n
@@ -33,7 +36,7 @@ function svdfact!(X; sorted=true, thin=true)
3336
t ? SVD(Vt',S,U') : SVD(U,S,Vt)
3437
end
3538

36-
function svdvals!(X; sorted=true)
39+
function generic_svdvals!(X::AbstractMatrix; sorted=true)
3740
m,n = size(X)
3841
if m < n
3942
X = X'

0 commit comments

Comments
 (0)