Merge pull request #241 from vincentcp/adjointA

move adjoint outside of loop

Author: haampie

src/lsmr.jl

@@ -114,7 +114,8 @@ function lsmr_method!(log::ConvergenceHistory, x, A, b, v, h, hbar;
     u = b
     β = norm(u)
     u .*= inv(β)
-    mul!(v, adjoint(A), u)
+    adjointA = adjoint(A)
+    mul!(v, adjointA, u)
     α = norm(v)
     v .*= inv(α)
 
@@ -168,7 +169,7 @@ function lsmr_method!(log::ConvergenceHistory, x, A, b, v, h, hbar;
             if β > 0
                 log.mtvps+=1
                 u .*= inv(β)
-                mul!(tmp_v, adjoint(A), u)
+                mul!(tmp_v, adjointA, u)
                 v .= tmp_v .+ v .* -β
                 α = norm(v)
                 v .*= inv(α)

src/lsqr.jl

@@ -123,10 +123,11 @@ function lsqr_method!(log::ConvergenceHistory, x, A, b;
     v = copy(x)
     beta = norm(u)
     alpha = zero(Tr)
+    adjointA = adjoint(A)
     if beta > 0
         log.mtvps=1
         u .*= inv(beta)
-        mul!(v, adjoint(A), u)
+        mul!(v, adjointA, u)
         alpha = norm(v)
     end
     if alpha > 0
@@ -166,7 +167,7 @@ function lsqr_method!(log::ConvergenceHistory, x, A, b;
             Anorm = sqrt(abs2(Anorm) + abs2(alpha) + abs2(beta) + dampsq)
             # Note that the following three lines are a band aid for a GEMM: X: C := αA'B + βC.
             # This is already supported in mul! for sparse and distributed matrices, but not yet dense
-            mul!(tmpn, adjoint(A), u)
+            mul!(tmpn, adjointA, u)
             v .= -beta .* v .+ tmpn
             alpha  = norm(v)
             if alpha > 0

src/svdl.jl

@@ -559,9 +559,10 @@ function extend!(
     end
 
     β = L.β
+    adjointA = adjoint(A)
     for j=l+1:k
         log.mtvps+=1
-        mul!(q, adjoint(A), p) #q = A'p
+        mul!(q, adjointA, p) #q = A'p
 
         if orthright #Orthogonalize right Lanczos vector
             #Do double classical Gram-Schmidt reorthogonalization