Check output size for FunctionMaps (#161)

Author: JeffFessler

Project.toml

@@ -1,6 +1,6 @@
 name = "LinearMaps"
 uuid = "7a12625a-238d-50fd-b39a-03d52299707e"
-version = "3.4.0"
+version = "3.4.1"
 
 [deps]
 LinearAlgebra = "37e2e46d-f89d-539d-b4ee-838fcccc9c8e"

src/functionmap.jl

@@ -37,12 +37,13 @@ const TransposeFunctionMap = TransposeMap{<:Any, <:FunctionMap}
 const AdjointFunctionMap = AdjointMap{<:Any, <:FunctionMap}
 
 function Base.:(*)(A::FunctionMap, x::AbstractVector)
-    length(x) == A.N || throw(DimensionMismatch())
+    length(x) == size(A, 2) || throw(DimensionMismatch())
     if ismutating(A)
-        y = similar(x, promote_type(eltype(A), eltype(x)), A.M)
+        y = similar(x, promote_type(eltype(A), eltype(x)), size(A, 1))
         A.f(y, x)
     else
         y = A.f(x)
+        length(y) == size(A, 1) || throw(DimensionMismatch())
     end
     return y
 end
@@ -56,6 +57,7 @@ function Base.:(*)(A::AdjointFunctionMap, x::AbstractVector)
             Afun.fc(y, x)
         else
             y = Afun.fc(x)
+            length(y) == size(A, 1) || throw(DimensionMismatch())
         end
         return y
     elseif issymmetric(Afun) # but !isreal(A), Afun.f can be used
@@ -65,6 +67,7 @@ function Base.:(*)(A::AdjointFunctionMap, x::AbstractVector)
             Afun.f(y, x)
         else
             y = Afun.f(x)
+            length(y) == size(A, 1) || throw(DimensionMismatch())
         end
         conj!(y)
         return y
@@ -85,6 +88,7 @@ function Base.:(*)(A::TransposeFunctionMap, x::AbstractVector)
             Afun.fc(y, x)
         else
             y = Afun.fc(x)
+            length(y) == size(A, 1) || throw(DimensionMismatch())
         end
         if !isreal(A)
             conj!(y)
@@ -97,6 +101,7 @@ function Base.:(*)(A::TransposeFunctionMap, x::AbstractVector)
             Afun.f(y, x)
         else
             y = Afun.f(x)
+            length(y) == size(A, 1) || throw(DimensionMismatch())
         end
         conj!(y)
         return y