Minor cleanup (#153)

Author: dkarrasch

src/blockmap.jl

@@ -262,7 +262,6 @@ function LinearAlgebra.issymmetric(A::BlockMap)
     return true
 end
 
-LinearAlgebra.ishermitian(A::BlockMap{<:Real}) = issymmetric(A)
 function LinearAlgebra.ishermitian(A::BlockMap)
     isblocksquare(A) || return false
     N = length(A.rows)
@@ -482,7 +481,6 @@ Base.size(A::BlockDiagonalMap) = (last(A.rowranges[end]), last(A.colranges[end])
 MulStyle(A::BlockDiagonalMap) = MulStyle(A.maps...)
 
 LinearAlgebra.issymmetric(A::BlockDiagonalMap) = all(issymmetric, A.maps)
-LinearAlgebra.ishermitian(A::BlockDiagonalMap{<:Real}) = all(issymmetric, A.maps)
 LinearAlgebra.ishermitian(A::BlockDiagonalMap) = all(ishermitian, A.maps)
 
 LinearAlgebra.adjoint(A::BlockDiagonalMap{T}) where {T} =

src/kronecker.jl

@@ -102,7 +102,6 @@ Base.:(^)(A::MapOrMatrix, ::KronPower{p}) where {p} =
 Base.size(A::KroneckerMap) = map(*, size.(A.maps)...)
 
 LinearAlgebra.issymmetric(A::KroneckerMap) = all(issymmetric, A.maps)
-LinearAlgebra.ishermitian(A::KroneckerMap{<:Real}) = issymmetric(A)
 LinearAlgebra.ishermitian(A::KroneckerMap) = all(ishermitian, A.maps)
 
 LinearAlgebra.adjoint(A::KroneckerMap) = KroneckerMap{eltype(A)}(map(adjoint, A.maps))
@@ -288,7 +287,6 @@ Base.size(A::KroneckerSumMap, i) = prod(size.(A.maps, i))
 Base.size(A::KroneckerSumMap) = (size(A, 1), size(A, 2))
 
 LinearAlgebra.issymmetric(A::KroneckerSumMap) = all(issymmetric, A.maps)
-LinearAlgebra.ishermitian(A::KroneckerSumMap{<:Real}) = all(issymmetric, A.maps)
 LinearAlgebra.ishermitian(A::KroneckerSumMap) = all(ishermitian, A.maps)
 
 LinearAlgebra.adjoint(A::KroneckerSumMap) =

src/wrappedmap.jl

@@ -12,12 +12,12 @@ function WrappedMap{T}(lmap::MapOrMatrix;
 end
 WrappedMap(lmap::MapOrMatrix{T}; kwargs...) where {T} = WrappedMap{T}(lmap; kwargs...)
 function WrappedMap{T}(lmap::AbstractVector;
-                        issymmetric::Bool = false,
-                        ishermitian::Bool = false,
-                        isposdef::Bool = false) where {T}
+                        issym::Bool = false,
+                        isherm::Bool = false,
+                        ispd::Bool = false) where {T}
     WrappedMap{T, typeof(lmap)}(lmap,
-                                length(lmap) == 1 && isreal(T),
-                                length(lmap) == 1 && isreal(T),
+                                length(lmap) == 1 && issymmetric(first(lmap)),
+                                length(lmap) == 1 && ishermitian(first(lmap)),
                                 length(lmap) == 1 && isposdef(first(lmap)))
 end
 WrappedMap(lmap::AbstractVector{T}; kwargs...) where {T} = WrappedMap{T}(lmap; kwargs...)

test/scaledmap.jl

@@ -80,7 +80,7 @@ using Test, LinearMaps, LinearAlgebra, BenchmarkTools
     A = LinearMap{Float32}(rand(N, 2)) # rank=2 w.p.1
     B = @inferred β * A
     C = @inferred B' * B
-    @test @inferred isposdef(C)
+    @test @inferred isposdef(C.λ)
 
     N = 2^8
     A0 = LinearMap{T}(cumsum, reverse ∘ cumsum ∘ reverse, N) # out-of-place

test/wrappedmap.jl

@@ -84,4 +84,16 @@ using Test, LinearMaps, LinearAlgebra
     @test mul!(B, Id, A, true, true) ≈ 2A
     @test mul!(B, A, Id, true, true) == B == 3A
     @test mul!(copy(B), A, LinearMap(Matrix(Id)), true, true) == 4A
+
+    # wrapped vectors viewed as column matrices
+    u = ones(1); U = @inferred LinearMap(u)
+    @test U isa LinearMap{Float64}
+    @test issymmetric(U)
+    @test ishermitian(U)
+    @test isposdef(U)
+    U = @inferred LinearMap(u.*im)
+    @test U isa LinearMap{ComplexF64}
+    @test issymmetric(U)
+    @test !ishermitian(U)
+    @test !isposdef(U)
 end