Skip to content

Commit 20b7960

Browse files
committed
Update threshold, and add comments
1 parent 18f5720 commit 20b7960

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

src/lu.jl

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,11 @@ end
1111

1212
function lu!(A::AbstractMatrix{T}, ipiv::AbstractVector{<:Integer},
1313
pivot::Union{Val{false}, Val{true}} = Val(true);
14-
check::Bool=true, blocksize::Integer=16, threshold::Integer=192) where T
14+
check::Bool=true,
15+
# the performance is not sensitive wrt blocksize, and 16 is a good default
16+
blocksize::Integer=16,
17+
# OpenBLAS' TRSM isn't very good, we use a higher threshold for recursion
18+
threshold::Integer=BLAS.vendor() === :mkl ? 48 : 192) where T
1519
info = Ref(zero(BlasInt))
1620
m, n = size(A)
1721
mnmin = min(m, n)

0 commit comments

Comments
 (0)