Skip to content

syntax fix for Base.:(==) #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 24, 2025
Merged

syntax fix for Base.:(==) #148

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/CI.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
fail-fast: false
matrix:
version:
- '1.6'
- 'min'
- '1' # automatically expands to the latest stable 1.x release of Julia
os:
- ubuntu-latest
Expand Down
2 changes: 1 addition & 1 deletion src/tridiag.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
and provides efficient specialized eigensolvers, but may be converted into a
regular matrix with `convert(Array, _)` (or `Array(_)` for short).
# Examples
```jldoctest

Check failure on line 23 in src/tridiag.jl

View workflow job for this annotation

GitHub Actions / Documentation 

doctest failure in ~/work/SkewLinearAlgebra.jl/SkewLinearAlgebra.jl/src/tridiag.jl:23-41

```jldoctest
julia> ev = complex.([7, 8, 9] , [7, 8, 9])
3-element Vector{Complex{Int64}}:
 7 + 7im
 8 + 8im
 9 + 9im
 julia> dvim =  [1, 2, 3, 4]
 4-element Vector{Int64}:
  1
  2
  3
  4
julia> SkewHermTridiagonal(ev, dvim)
4×4 SkewHermTridiagonal{Complex{Int64}, Vector{Complex{Int64}}, Vector{Int64}}:
 0+1im -7+7im  0+0im  0+0im
 7-7im  0+2im -8+8im  0+0im
 0+0im -8+8im  0+3im -9+9im
 0+0im  0+0im  9+9im  0+4im
```

Subexpression:

SkewHermTridiagonal(ev, dvim)

Evaluated output:

ERROR: UndefVarError: `dvim` not defined in `Main`
Suggestion: check for spelling errors or missing imports.
Stacktrace:
 [1] top-level scope
   @ none:1

Expected output:

4×4 SkewHermTridiagonal{Complex{Int64}, Vector{Complex{Int64}}, Vector{Int64}}:
 0+1im -7+7im  0+0im  0+0im
 7-7im  0+2im -8+8im  0+0im
 0+0im -8+8im  0+3im -9+9im
 0+0im  0+0im  9+9im  0+4im


  diff = 
    Warning: Diff output requires color.
    4×4 SkewHermTridiagonal{Complex{Int64}, Vector{Complex{Int64}}, Vector{Int64}}:
     0+1im -7+7im  0+0im  0+0im
     7-7im  0+2im -8+8im  0+0im
     0+0im -8+8im  0+3im -9+9im
     0+0im  0+0im  9+9im  0+4imERROR: UndefVarError: `dvim` not defined in `Main`
    Suggestion: check for spelling errors or missing imports.
    Stacktrace:
     [1] top-level scope
       @ none:1

Check failure on line 23 in src/tridiag.jl

View workflow job for this annotation

GitHub Actions / Documentation 

doctest failure in ~/work/SkewLinearAlgebra.jl/SkewLinearAlgebra.jl/src/tridiag.jl:23-41

```jldoctest
julia> ev = complex.([7, 8, 9] , [7, 8, 9])
3-element Vector{Complex{Int64}}:
 7 + 7im
 8 + 8im
 9 + 9im
 julia> dvim =  [1, 2, 3, 4]
 4-element Vector{Int64}:
  1
  2
  3
  4
julia> SkewHermTridiagonal(ev, dvim)
4×4 SkewHermTridiagonal{Complex{Int64}, Vector{Complex{Int64}}, Vector{Int64}}:
 0+1im -7+7im  0+0im  0+0im
 7-7im  0+2im -8+8im  0+0im
 0+0im -8+8im  0+3im -9+9im
 0+0im  0+0im  9+9im  0+4im
```

Subexpression:

ev = complex.([7, 8, 9] , [7, 8, 9])

Evaluated output:

3-element Vector{Complex{Int64}}:
 7 + 7im
 8 + 8im
 9 + 9im

Expected output:

3-element Vector{Complex{Int64}}:
 7 + 7im
 8 + 8im
 9 + 9im
 julia> dvim =  [1, 2, 3, 4]
 4-element Vector{Int64}:
  1
  2
  3
  4


  diff = 
    Warning: Diff output requires color.
    3-element Vector{Complex{Int64}}:
     7 + 7im
     8 + 8im
     9 + 9im
     julia> dvim =  [1, 2, 3, 4]
     4-element Vector{Int64}:
      1
      2
      3
      49im
julia> ev = complex.([7, 8, 9] , [7, 8, 9])
3-element Vector{Complex{Int64}}:
7 + 7im
Expand Down Expand Up @@ -55,7 +55,7 @@
Construct a skewhermitian tridiagonal matrix from first subdiagonal and main diagonal
of the skewhermitian matrix `A`.
# Examples
```jldoctest

Check failure on line 58 in src/tridiag.jl

View workflow job for this annotation

GitHub Actions / Documentation 

doctest failure in ~/work/SkewLinearAlgebra.jl/SkewLinearAlgebra.jl/src/tridiag.jl:58-69

```jldoctest
julia> A = [1 2 3; 2 4 5; 3 5 6]
3×3 Matrix{Int64}:
 1  2  3
 2  4  5
 3  5  6
julia> SkewHermTridiagonal(A)
3×3 SkewHermTridiagonal{Int64, Vector{Int64}}:
 0 -2  0
 2  0 -5
 0  5  0
```

Subexpression:

SkewHermTridiagonal(A)

Evaluated output:

ERROR: ArgumentError: matrix is not skew-hermitian; cannot convert to SkewHermTridiagonal
Stacktrace:
 [1] SkewHermTridiagonal(A::Matrix{Int64})
   @ SkewLinearAlgebra ~/work/SkewLinearAlgebra.jl/SkewLinearAlgebra.jl/src/tridiag.jl:84
 [2] top-level scope
   @ none:1

Expected output:

3×3 SkewHermTridiagonal{Int64, Vector{Int64}}:
 0 -2  0
 2  0 -5
 0  5  0


  diff = 
    Warning: Diff output requires color.
    3×3 SkewHermTridiagonal{Int64, Vector{Int64}}:
     0 -2  0
     2  0 -5
     0  5  0ERROR: ArgumentError: matrix is not skew-hermitian; cannot convert to SkewHermTridiagonal
    Stacktrace:
     [1] SkewHermTridiagonal(A::Matrix{Int64})
       @ SkewLinearAlgebra ~/work/SkewLinearAlgebra.jl/SkewLinearAlgebra.jl/src/tridiag.jl:84
     [2] top-level scope
       @ none:1
julia> A = [1 2 3; 2 4 5; 3 5 6]
3×3 Matrix{Int64}:
1 2 3
Expand Down Expand Up @@ -312,7 +312,7 @@
end
end

function Base. ==(A::SkewHermTridiagonal, B::SkewHermTridiagonal)
function Base.:(==)(A::SkewHermTridiagonal, B::SkewHermTridiagonal)
if A.dvim !== nothing && B.dvim!== nothing
return (A.ev==B.ev) &&(A.dvim==B.dvim)
elseif A.dvim === nothing && B.dvim === nothing
Expand Down
Loading