Stop building with -Werror (#81)

* Stop building with `-Werror`

`-Werror` should not be used in default build flags as it makes the compilation fail every time
somebody tries to build with a new version of the compiler which triggers a new warning.
It should only be set when running CI.

* Use `-Werror` on CI

* Update utils.jl

* Revert previous change

* Simplify logic

* Add missing parentheses

Author: nalimilan

src/Make.inc

@@ -53,7 +53,7 @@ else
   SONAME_FLAG := -Wl,-soname=$(LIB_MAJOR_VERSION)
 endif
 
-LBT_CFLAGS := -g -O2 -Werror -std=c99 $(FPIC) -DLIBRARY_EXPORTS -D_GNU_SOURCE $(CFLAGS)
+LBT_CFLAGS := -g -O2 -std=c99 $(FPIC) -DLIBRARY_EXPORTS -D_GNU_SOURCE $(CFLAGS)
 LBT_LDFLAGS := $(LDFLAGS)
 
 ifeq ($(OS),Linux)

test/utils.jl

@@ -61,11 +61,11 @@ function build_libblastrampoline()
         return blastrampoline_build_dir
     end
 
-    cflags_add = needs_m32() ? "-m32" : ""
+    cflags_add = "-Werror" * (needs_m32() ? " -m32" : "")
     dir = mktempdir()
     srcdir = joinpath(dirname(@__DIR__), "src")
-    run(`$(make) -sC $(pathesc(srcdir)) CFLAGS=$(cflags_add) ARCH=$(Sys.ARCH) clean`)
-    run(`$(make) -sC $(pathesc(srcdir)) CFLAGS=$(cflags_add) ARCH=$(Sys.ARCH) install builddir=$(pathesc(dir))/build prefix=$(pathesc(dir))/output`)
+    run(`$(make) -sC $(pathesc(srcdir)) CFLAGS="$(cflags_add)" ARCH=$(Sys.ARCH) clean`)
+    run(`$(make) -sC $(pathesc(srcdir)) CFLAGS="$(cflags_add)" ARCH=$(Sys.ARCH) install builddir=$(pathesc(dir))/build prefix=$(pathesc(dir))/output`)
 
     global blastrampoline_build_dir = joinpath(dir, "output")