make FileLogger a pure sink

Author: oxinabox

src/filelogger.jl

@@ -7,16 +7,16 @@ struct FileLogger <: AbstractLogger
     always_flush::Bool
 end
 
-function FileLogger(path::AbstractString; min_level=Info, append=false, always_flush=true)
+function FileLogger(path; append=false, always_flush=true)
     filehandle = open(path, append ? "a" : "w")
-    FileLogger(SimpleLogger(filehandle, min_level), always_flush)
+    FileLogger(SimpleLogger(filehandle, BelowMinLevel), always_flush)
 end
 
 
-function handle_message(filelogger::FileLogger, level, message, _module, group, id, file, line; kwargs...)
-	handle_message(filelogger.logger, level, message, _module, group, id, file, line; kwargs...)
+function handle_message(filelogger::FileLogger, args...; kwargs...)
+	handle_message(filelogger.logger, args...; kwargs...)
     filelogger.always_flush && flush(filelogger.logger.stream)
 end
-shouldlog(filelogger::FileLogger, level, _module, group, id) = shouldlog(filelogger.logger, level, _module, group, id)
-min_enabled_level(filelogger::FileLogger) = min_enabled_level(filelogger.logger)
+shouldlog(filelogger::FileLogger, arg...) = true
+min_enabled_level(filelogger::FileLogger) = BelowMinLevel
 catch_exceptions(filelogger::FileLogger) = catch_exceptions(filelogger.logger)

test/runtests.jl

@@ -6,8 +6,6 @@ using Base.CoreLogging: Debug, Info, Warn
 using Test: collect_test_logs, TestLogger
 
 
-
-
 @testset "Demux" begin
     testlogger_info = TestLogger(min_level=Info)
     testlogger_warn = TestLogger(min_level=Warn)
@@ -22,8 +20,6 @@ using Test: collect_test_logs, TestLogger
 
 end
 
-
-
 @testset "Filter" begin
     testlogger = TestLogger()
     yodawg_filter(lvl, msg, args...; kwargs...) = startswith(msg, "Yo Dawg!")