Skip to content

Commit b20b42e

Browse files
committed
add broken test
1 parent caf7b94 commit b20b42e

File tree

2 files changed

+10
-1
lines changed

2 files changed

+10
-1
lines changed

src/overridelogger.jl

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@ handle_message(logger::LevelOverrideLogger, args...; kwargs...) =
1616

1717
function shouldlog(logger::LevelOverrideLogger, level, args...)
1818
# Ignore the logger.logger's own level and instead check the override level
19-
@show level, logger.level
2019
level >= logger.level && shouldlog(logger.logger, level, args...)
2120
end
2221

test/runtests.jl

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -259,6 +259,16 @@ end
259259
end
260260
@test length(logger.logs) == 2
261261
@test map(x -> x.level, logger.logs) == [Debug, Debug-1]
262+
263+
logger = TestLogger(min_level=Info)
264+
with_logger(logger) do
265+
with_logger(MinLevelLogger(current_logger(), Info)) do
266+
LoggingExtras.withlevel(Debug; verbosity=1) do
267+
@debug "This should show up, even though it is behind 2 info level filters"
268+
end
269+
end
270+
end
271+
@test_broken length(logger.logs) == 1
262272
end
263273

264274
@testset "Deprecations" begin

0 commit comments

Comments
 (0)