Skip to content

Commit 7e5b00c

Browse files
committed
Move initialisations to match how they are written to the file
1 parent 58ba28c commit 7e5b00c

File tree

1 file changed

+7
-6
lines changed

1 file changed

+7
-6
lines changed

src/hparams.jl

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -115,17 +115,18 @@ function write_hparams!(logger::TBLogger, hparams::Dict{String, Any}, metrics::A
115115
# NOTE: THE ABOVE DICTIONARY IS NOT BEING SERIALISED TO THE FILE PROPERLY,
116116
# WE MAY NEED TO EXPLICITLY WRITE AN ENCODER/DECODER FOR THIS TYPE.
117117

118-
session_start_info = HP.SessionStartInfo(hparams_dict, "", "", "", zero(Float64))
119-
session_start_content = HP.HParamsPluginData(PLUGIN_DATA_VERSION, OneOf(:session_start_info, session_start_info))
120-
session_start_md = SummaryMetadata(SummaryMetadata_PluginData(PLUGIN_NAME, encode_bytes(session_start_content)), PLUGIN_NAME, "", DataClass.DATA_CLASS_UNKNOWN)
121-
session_start_summary = Summary([Summary_Value("", SESSION_START_INFO_TAG, session_start_md, nothing)])
122118

123-
experiment = HP.Experiment("", "", "", zero(Float64), hparam_infos, metric_infos)
119+
experiment = HP.Experiment("", "", "", time(), hparam_infos, metric_infos)
124120
experiment_content = HP.HParamsPluginData(PLUGIN_DATA_VERSION, OneOf(:experiment, experiment))
125121
experiment_md = SummaryMetadata(SummaryMetadata_PluginData(PLUGIN_NAME, encode_bytes(experiment_content)), "", "", DataClass.DATA_CLASS_UNKNOWN)
126122
experiment_summary = Summary([Summary_Value("", EXPERIMENT_TAG, experiment_md, nothing)])
127123

128-
session_end_info = HP.SessionEndInfo(HP.Status.STATUS_SUCCESS, zero(Float64))
124+
session_start_info = HP.SessionStartInfo(hparams_dict, "", "", "", time())
125+
session_start_content = HP.HParamsPluginData(PLUGIN_DATA_VERSION, OneOf(:session_start_info, session_start_info))
126+
session_start_md = SummaryMetadata(SummaryMetadata_PluginData(PLUGIN_NAME, encode_bytes(session_start_content)), "", "", DataClass.DATA_CLASS_UNKNOWN)
127+
session_start_summary = Summary([Summary_Value("", SESSION_START_INFO_TAG, session_start_md, nothing)])
128+
129+
session_end_info = HP.SessionEndInfo(HP.Status.STATUS_SUCCESS, time())
129130
session_end_content = HP.HParamsPluginData(PLUGIN_DATA_VERSION, OneOf(:session_end_info, session_end_info))
130131
session_end_md = SummaryMetadata(SummaryMetadata_PluginData(PLUGIN_NAME, encode_bytes(session_end_content)), "", "", DataClass.DATA_CLASS_UNKNOWN)
131132
session_end_summary = Summary([Summary_Value("", SESSION_END_INFO_TAG, session_end_md, nothing)])

0 commit comments

Comments
 (0)