Skip to content

Commit c02cd5a

Browse files
committed
Added a note of what to do next
1 parent a357f35 commit c02cd5a

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

src/hparams.jl

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -108,6 +108,8 @@ function write_hparams!(logger::TBLogger, hparams::Dict{String, Any}, metrics::A
108108

109109

110110
hparams_dict = Dict(k=>_convert_value(v) for (k,v) in hparams)
111+
# NOTE: THE ABOVE DICTIONARY IS NOT BEING SERIALISED TO THE FILE PROPERLY,
112+
# WE MAY NEED TO EXPLICITLY WRITE AN ENCODER/DECODER FOR THIS TYPE.
111113

112114
session_start_info = HP.SessionStartInfo(hparams_dict, "", "", "", zero(Float64))
113115
session_start_content = HP.HParamsPluginData(PLUGIN_DATA_VERSION, OneOf(:session_start_info, session_start_info))

0 commit comments

Comments
 (0)