Skip to content

Commit 7bba084

Browse files
committed
Fix broken HDF5 string tests
1 parent 3ecc35b commit 7bba084

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

test/containers/hdf5dataset.jl

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,8 @@ function setup_hdf5dataset_test()
22
datasets = [
33
("d1", rand(2, 10)),
44
("g1/d1", rand(10)),
5-
# these are broken at HDF5 level
6-
# ("g1/d2", string.('a':'j')),
7-
# ("g2/g1/d1", "test")
5+
("g1/d2", string.('a':'j')),
6+
("g2/g1/d1", "test")
87
]
98

109
fid = h5open("test.h5", "w")
@@ -20,7 +19,7 @@ end
2019
paths, datas = setup_hdf5dataset_test()
2120
dataset = HDF5Dataset("test.h5", paths)
2221
for i in 1:10
23-
data = Tuple(map(x -> getobs(x, i), datas))
22+
data = Tuple(map(x -> (x isa String) ? x : getobs(x, i), datas))
2423
@test getobs(dataset, i) == data
2524
end
2625
@test numobs(dataset) == 10

0 commit comments

Comments
 (0)