Skip to content

Commit 950e111

Browse files
committed
Switch to MLUtils v0.2
1 parent 7db9468 commit 950e111

File tree

6 files changed

+18
-18
lines changed

6 files changed

+18
-18
lines changed

Project.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ ImageCore = "0.2, 0.3, 0.4, 0.5, 0.6, 0.7, 0.8"
4040
JLD2 = "0.4.21"
4141
JSON3 = "1"
4242
MAT = "0.7, 0.8, 0.9, 0.10"
43-
MLUtils = "0.1.4"
43+
MLUtils = "0.2.0"
4444
Pickle = "0.2, 0.3"
4545
Requires = "1"
4646
Tables = "1.6"

src/containers/cacheddataset.jl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,9 +31,9 @@ function CachedDataset(source, cachesize::Int = numobs(source))
3131
CachedDataset(source, collect(cacheidx), make_cache(source, cacheidx))
3232
end
3333

34-
function MLUtils.getobs(dataset::CachedDataset, i::Integer)
34+
function Base.getindex(dataset::CachedDataset, i::Integer)
3535
_i = findfirst(==(i), dataset.cacheidx)
3636

3737
return isnothing(_i) ? getobs(dataset.source, i) : getobs(dataset.cache, _i)
3838
end
39-
MLUtils.numobs(dataset::CachedDataset) = numobs(dataset.source)
39+
Base.length(dataset::CachedDataset) = numobs(dataset.source)

src/containers/filedataset.jl

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,6 @@ FileDataset(loadfn,
5252
FileDataset(dir::Union{AbstractPath, AbstractString}, pattern::AbstractString = "*", depth = 4) =
5353
FileDataset(loadfile, dir, pattern, depth)
5454

55-
MLUtils.getobs(dataset::FileDataset, i::Integer) = loadfile(dataset.paths[i])
56-
MLUtils.getobs(dataset::FileDataset, is::AbstractVector) = map(Base.Fix1(getobs, dataset), is)
57-
MLUtils.numobs(dataset::FileDataset) = length(dataset.paths)
55+
Base.getindex(dataset::FileDataset, i::Integer) = loadfile(dataset.paths[i])
56+
Base.getindex(dataset::FileDataset, is::AbstractVector) = map(Base.Fix1(getobs, dataset), is)
57+
Base.length(dataset::FileDataset) = length(dataset.paths)

src/containers/hdf5dataset.jl

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -47,11 +47,11 @@ function _getobs_hdf5(dataset::HDF5.Dataset, shape, i)
4747

4848
return dataset[I..., i]
4949
end
50-
MLUtils.getobs(dataset::HDF5Dataset{HDF5.Dataset}, i) =
50+
Base.getindex(dataset::HDF5Dataset{HDF5.Dataset}, i) =
5151
_getobs_hdf5(dataset.paths, only(dataset.shapes), i)
52-
MLUtils.getobs(dataset::HDF5Dataset{<:Vector}, i) =
52+
Base.getindex(dataset::HDF5Dataset{<:Vector}, i) =
5353
Tuple(map((p, s) -> _getobs_hdf5(p, s, i), dataset.paths, dataset.shapes))
54-
MLUtils.numobs(dataset::HDF5Dataset) = last(first(filter(!isempty, dataset.shapes)))
54+
Base.length(dataset::HDF5Dataset) = last(first(filter(!isempty, dataset.shapes)))
5555

5656
"""
5757
close(dataset::HDF5Dataset)

src/containers/jld2dataset.jl

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -28,9 +28,9 @@ JLD2Dataset(file::JLD2.JLDFile, path::String) = JLD2Dataset(file, (path,))
2828
JLD2Dataset(file::Union{AbstractString, AbstractPath}, paths) =
2929
JLD2Dataset(jldopen(file, "r"), paths)
3030

31-
MLUtils.getobs(dataset::JLD2Dataset{<:JLD2.JLDFile, <:NTuple{1}}, i) = getobs(only(dataset.paths), i)
32-
MLUtils.getobs(dataset::JLD2Dataset, i) = map(Base.Fix2(getobs, i), dataset.paths)
33-
MLUtils.numobs(dataset::JLD2Dataset) = numobs(dataset.paths[1])
31+
Base.getindex(dataset::JLD2Dataset{<:JLD2.JLDFile, <:NTuple{1}}, i) = getobs(only(dataset.paths), i)
32+
Base.getindex(dataset::JLD2Dataset, i) = map(Base.Fix2(getobs, i), dataset.paths)
33+
Base.length(dataset::JLD2Dataset) = numobs(dataset.paths[1])
3434

3535
"""
3636
close(dataset::JLD2Dataset)

src/containers/tabledataset.jl

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ function _getobs_column(x, i)
3030

3131
return NamedTuple{colnames}(rowvals)
3232
end
33-
function MLUtils.getobs(dataset::TableDataset, i)
33+
function Base.getindex(dataset::TableDataset, i)
3434
if Tables.rowaccess(dataset.table)
3535
return _getobs_row(Tables.rows(dataset.table), i)
3636
elseif Tables.columnaccess(dataset.table)
@@ -39,7 +39,7 @@ function MLUtils.getobs(dataset::TableDataset, i)
3939
error("The Tables.jl implementation used should have either rowaccess or columnaccess.")
4040
end
4141
end
42-
function MLUtils.numobs(dataset::TableDataset)
42+
function Base.length(dataset::TableDataset)
4343
if Tables.columnaccess(dataset.table)
4444
return length(Tables.getcolumn(dataset.table, 1))
4545
elseif Tables.rowaccess(dataset.table)
@@ -51,9 +51,9 @@ function MLUtils.numobs(dataset::TableDataset)
5151
end
5252

5353
# fast access for DataFrame
54-
MLUtils.getobs(dataset::TableDataset{<:DataFrame}, i) = dataset.table[i, :]
55-
MLUtils.numobs(dataset::TableDataset{<:DataFrame}) = nrow(dataset.table)
54+
Base.getindex(dataset::TableDataset{<:DataFrame}, i) = dataset.table[i, :]
55+
Base.length(dataset::TableDataset{<:DataFrame}) = nrow(dataset.table)
5656

5757
# fast access for CSV.File
58-
MLUtils.getobs(dataset::TableDataset{<:CSV.File}, i) = dataset.table[i]
59-
MLUtils.numobs(dataset::TableDataset{<:CSV.File}) = length(dataset.table)
58+
Base.getindex(dataset::TableDataset{<:CSV.File}, i) = dataset.table[i]
59+
Base.length(dataset::TableDataset{<:CSV.File}) = length(dataset.table)

0 commit comments

Comments
 (0)