Fix regression with building empty dataloaders#203
Merged
CarloLucibello merged 1 commit intoJuliaML:mainfrom Mar 22, 2025
Merged
Fix regression with building empty dataloaders#203CarloLucibello merged 1 commit intoJuliaML:mainfrom
CarloLucibello merged 1 commit intoJuliaML:mainfrom
Conversation
One of the obsview changes seems to have broken downstream workflows, where empty DataLoaders used to be accepted but now they error. This reverts back to the previous behavior in this edge case as it's relied upon in some libraries for handling the case of test/train splits of 0% and 100% while being stable. Found in https://github.com/SciML/ModelingToolkit.jl/actions/runs/13965380427/job/39094470015
Contributor
Author
|
Bump? This one should be a rather simple patch because it's just a regression fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One of the obsview changes seems to have broken downstream workflows, where empty DataLoaders used to be accepted but now they error. This reverts back to the previous behavior in this edge case as it's relied upon in some libraries for handling the case of test/train splits of 0% and 100% while being stable.
Found in https://github.com/SciML/ModelingToolkit.jl/actions/runs/13965380427/job/39094470015