SciMLOperators v1 compat (#45)

Author: mateuszbaran

NEWS.md

@@ -5,17 +5,18 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
-## [0.2.6] - unreleased
+## [0.2.6] - 2025-10-21
 
 ### Changed
 
 * `CompatHelper` bumped to v3.
+* Compatibility with `SciMLOperators` v1.
 
 ## [0.2.5] - 2025-10-18
 
 ### Added
 
-* Compatibility with SciMLOperators v0.4
+* Compatibility with `SciMLOperators` v0.4
 
 ### Fixed
 

Project.toml

@@ -1,6 +1,6 @@
 name = "ManifoldDiffEq"
 uuid = "1143c485-9b25-4e23-a65f-701df382ec90"
-version = "0.2.5"
+version = "0.2.6"
 authors = ["Seth Axen <[email protected]>", "Mateusz Baran <[email protected]>", "Ronny Bergmann <[email protected]>", "Antoine Levitt <[email protected]>"]
 
 [deps]
@@ -31,7 +31,7 @@ Markdown = "1.6"
 OrdinaryDiffEqCore = "1"
 RecursiveArrayTools = "2, 3"
 SciMLBase = "1, 2"
-SciMLOperators = "0.3.13, 0.4"
+SciMLOperators = "1"
 SimpleUnPack = "1"
 julia = "1.10"
 

src/ManifoldDiffEq.jl

@@ -438,73 +438,57 @@ function SciMLBase.__init(
         save_everystep || isempty(saveat) || saveat isa Number || prob.tspan[2] in saveat :
         save_end
 
+    save_idxs = nothing
+    internalnorm = ODE_DEFAULT_NORM
+    save_discretes = true
+
     opts = DEOptions{
-        typeof(abstol_internal),
-        typeof(reltol_internal),
-        QT,
-        tType,
-        typeof(controller),
-        typeof(ODE_DEFAULT_NORM),
-        typeof(internalopnorm),
+        typeof(abstol_internal), typeof(reltol_internal),
+        QT, tType, typeof(controller),
+        typeof(internalnorm), typeof(internalopnorm),
         typeof(save_end_user),
         typeof(callbacks_internal),
         typeof(isoutofdomain),
-        typeof(progress_message),
-        typeof(unstable_check),
+        typeof(progress_message), typeof(unstable_check),
         typeof(tstops_internal),
-        typeof(d_discontinuities_internal),
-        typeof(userdata),
-        typeof(nothing),
-        typeof(maxiters),
-        typeof(tstops),
-        typeof(saveat),
-        typeof(d_discontinuities),
+        typeof(d_discontinuities_internal), typeof(userdata),
+        typeof(save_idxs),
+        typeof(maxiters), typeof(tstops),
+        typeof(saveat), typeof(d_discontinuities),
     }(
-        maxiters,
-        save_everystep,
-        adaptive,
-        abstol_internal,
+        maxiters, save_everystep,
+        adaptive, abstol_internal,
         reltol_internal,
-        QT(gamma),
-        QT(qmax),
+        QT(gamma), QT(qmax),
         QT(qmin),
         QT(qsteady_max),
         QT(qsteady_min),
         QT(qoldinit),
         QT(failfactor),
-        tType(dtmax),
-        tType(dtmin),
+        tType(dtmax), tType(dtmin),
         controller,
-        ODE_DEFAULT_NORM,
+        internalnorm,
         internalopnorm,
-        nothing, # save_idxs
-        tstops_internal,
+        save_idxs, tstops_internal,
         saveat_internal,
         d_discontinuities_internal,
-        tstops,
-        saveat,
+        tstops, saveat,
         d_discontinuities,
-        userdata,
-        progress,
+        userdata, progress,
         progress_steps,
         progress_name,
         progress_message,
         progress_id,
         timeseries_errors,
-        dense_errors,
-        dense,
-        save_on,
-        save_start,
-        save_end,
-        save_end_user,
+        dense_errors, dense,
+        save_on, save_start,
+        save_end, save_discretes, save_end_user,
         callbacks_internal,
         isoutofdomain,
         unstable_check,
-        verbose,
-        calck,
-        force_dtmin,
+        verbose, calck, force_dtmin,
         advance_to_tstop,
-        stop_at_next_tstop,
+        stop_at_next_tstop
     )
 
     stats = SciMLBase.DEStats(0)

src/operators.jl

@@ -51,10 +51,10 @@ function FrozenManifoldDiffEqOperator{T}(f) where {T <: Number}
     )
 end
 
-function (L::FrozenManifoldDiffEqOperator)(du, u, p, t)
+function (L::FrozenManifoldDiffEqOperator)(du, u, _u, p, t)
     return copyto!(du, L.func(u, p, t))
 end
-function (L::FrozenManifoldDiffEqOperator)(u, p, t)
+function (L::FrozenManifoldDiffEqOperator)(u, _u, p, t)
     return L.func(u, p, t)
 end
 
@@ -72,9 +72,9 @@ function LieManifoldDiffEqOperator{T}(f) where {T <: Number}
     return LieManifoldDiffEqOperator{T, typeof(f)}(f)
 end
 
-function (L::LieManifoldDiffEqOperator)(du, u, p, t)
+function (L::LieManifoldDiffEqOperator)(du, u, _u, p, t)
     return copyto!(du, L.func(u, p, t))
 end
-function (L::LieManifoldDiffEqOperator)(u, p, t)
+function (L::LieManifoldDiffEqOperator)(u, _u, p, t)
     return L.func(u, p, t)
 end