Skip to content

Commit 56212e1

Browse files
authored
Fix retracts in LineSearches extension (#471)
* Fix two `retract!` calls, that since `ManifoldsBase`1.0 are `retract_fused!`s * bump version * Fix Documenter version ro 1.10.2 for a while.
1 parent 6aed8f9 commit 56212e1

File tree

4 files changed

+11
-4
lines changed

4 files changed

+11
-4
lines changed

Changelog.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,13 @@ The file was started with Version `0.4`.
66
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
77
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
88

9+
## [0.5.16] 2025-05-07
10+
11+
### Fixed
12+
13+
* fixes a bug in the `LineSearches.jl` extension, where two (old) `retract!`s were still
14+
present; they were changed to `retact_fused!`.
15+
916
## [0.5.15] 2025-05-06
1017

1118
### Fixed

Project.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
name = "Manopt"
22
uuid = "0fc0a36d-df90-57f3-8f93-d78a9fc72bb5"
33
authors = ["Ronny Bergmann <[email protected]>"]
4-
version = "0.5.15"
4+
version = "0.5.16"
55

66
[deps]
77
ColorSchemes = "35d6a980-a343-548e-a6ea-1d62b119f2f4"

docs/Project.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ BenchmarkTools = "1.3"
2828
CSV = "0.10"
2929
Colors = "0.12, 0.13"
3030
DataFrames = "1"
31-
Documenter = "1"
31+
Documenter = "=1.10.2"
3232
DocumenterCitations = "1"
3333
DocumenterInterLinks = "0.3, 1"
3434
FiniteDifferences = "0.12"

ext/ManoptLineSearchesExt.jl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,11 +28,11 @@ function (cs::Manopt.LineSearchesStepsize)(
2828
# perform actual line-search
2929

3030
function ϕ(α)
31-
retract!(M, p_tmp, p, η, α, cs.retraction_method)
31+
ManifoldsBase.retract_fused!(M, p_tmp, p, η, α, cs.retraction_method)
3232
return f(M, p_tmp)
3333
end
3434
function (α)
35-
retract!(M, p_tmp, p, η, α, cs.retraction_method)
35+
ManifoldsBase.retract_fused!(M, p_tmp, p, η, α, cs.retraction_method)
3636
get_gradient!(mp, X_tmp, p_tmp)
3737
vector_transport_to!(M, Y_tmp, p, η, p_tmp, cs.vector_transport_method)
3838
return real(inner(M, p_tmp, X_tmp, Y_tmp))

0 commit comments

Comments
 (0)