Skip to content

Commit 04a14f5

Browse files
authored
fix(docs): Update Documenter setup (#144)
* fix(docs): Update compat restriction for Documenter * fix(docs): Move the comment before `Base.adjoint` before docstring * fix(deps): Add source to the AbstractFFTs This should keep the source that is documented to be the HEAD version instead of the one in the registry. * refactor(CI): Remove the unnecessary doc configuration
1 parent 9a167f9 commit 04a14f5

File tree

3 files changed

+7
-5
lines changed

3 files changed

+7
-5
lines changed

.github/workflows/Documenter.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,6 @@ jobs:
4242
shell: julia --project=docs --color=yes {0}
4343
run: |
4444
using Pkg
45-
Pkg.develop(PackageSpec(path=pwd()))
4645
Pkg.instantiate()
4746
- uses: julia-actions/julia-buildpkg@v1
4847
- run: julia --project=docs --color=yes docs/make.jl

docs/Project.toml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,5 +2,8 @@
22
AbstractFFTs = "621f4979-c628-5d54-868e-fcf4e3e8185c"
33
Documenter = "e30172f5-a6a5-5a46-863b-614d45cd2de4"
44

5+
[sources]
6+
AbstractFFTs = { path = ".." }
7+
58
[compat]
6-
Documenter = "~0.25"
9+
Documenter = "^1"

src/definitions.jl

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -649,6 +649,9 @@ struct AdjointPlan{T,P<:Plan} <: Plan{T}
649649
AdjointPlan{T,P}(p) where {T,P} = new(p)
650650
end
651651

652+
# We eagerly form the plan inverse in the adjoint(p) call, which will be cached for subsequent calls.
653+
# This is reasonable, as inv(p) would do the same, and necessary in order to compute the correct input
654+
# type for the adjoint plan and encode it in its type.
652655
"""
653656
(p::Plan)'
654657
adjoint(p::Plan)
@@ -659,9 +662,6 @@ Return a plan that performs the adjoint operation of the original plan.
659662
Adjoint plans do not currently support `LinearAlgebra.mul!`. Further, as a new addition to `AbstractFFTs`,
660663
coverage of `Base.adjoint` in downstream implementations may be limited.
661664
"""
662-
# We eagerly form the plan inverse in the adjoint(p) call, which will be cached for subsequent calls.
663-
# This is reasonable, as inv(p) would do the same, and necessary in order to compute the correct input
664-
# type for the adjoint plan and encode it in its type.
665665
Base.adjoint(p::Plan{T}) where {T} = AdjointPlan{eltype(inv(p)), typeof(p)}(p)
666666
Base.adjoint(p::AdjointPlan) = p.p
667667
# always have AdjointPlan inside ScaledPlan.

0 commit comments

Comments
 (0)