Generalise dual2array/array2dual for strided

Author: dlfivefifty

ext/AbstractFFTsForwardDiffExt.jl

@@ -9,10 +9,10 @@ import AbstractFFTs: Plan, mul!, dualplan, dual2array
 
 AbstractFFTs._fftfloat(::Type{Dual{T,V,N}}) where {T,V,N} = Dual{T,AbstractFFTs._fftfloat(V),N}
 
-dual2array(x::Array{<:Dual{Tag,T}}) where {Tag,T} = reinterpret(reshape, T, x)
-dual2array(x::Array{<:Complex{<:Dual{Tag, T}}}) where {Tag,T} = complex.(dual2array(real(x)), dual2array(imag(x)))
-array2dual(DT::Type{<:Dual}, x::Array{T}) where T = reinterpret(reshape, DT, real(x))
-array2dual(DT::Type{<:Dual}, x::Array{<:Complex{T}}) where T = complex.(array2dual(DT, real(x)), array2dual(DT, imag(x)))
+dual2array(x::StridedArray{<:Dual{Tag,T}}) where {Tag,T} = reinterpret(reshape, T, x)
+dual2array(x::StridedArray{<:Complex{<:Dual{Tag, T}}}) where {Tag,T} = complex.(dual2array(real(x)), dual2array(imag(x)))
+array2dual(DT::Type{<:Dual}, x::StridedArray{T}) where T = reinterpret(reshape, DT, real(x))
+array2dual(DT::Type{<:Dual}, x::StridedArray{<:Complex{T}}) where T = complex.(array2dual(DT, real(x)), array2dual(DT, imag(x)))
 
 
 ########

test/abstractfftsforwarddiff.jl

@@ -37,9 +37,6 @@ complexpartials(x, k) = partials(real(x), k) + im*partials(imag(x), k)
     # emperical from Mathematical
     @test ForwardDiff.derivative(ω -> fft(exp.(ω .* cos.(θ)))[1]/n, 1) ≈ 0.565159103992485
 
-    # c = x -> dct([x; 0; 0])[1]
-    # @test derivative(c,0.1) ≈ 1
-
     @testset "matrix" begin
         A = x1 * (1:10)'
         @test value.(fft(A)) == fft(value.(A))