fix all tests

Author: heltonmc

src/besselj.jl

@@ -272,8 +272,8 @@ function besselj_positive_args(nu::Real, x::T) where T
     # Shifting the order up decreases the value substantially for high orders and results in a stable forward recurrence
     # as the values rapidly increase
 
-    debye_cutoff = 2.0 + 1.00035*x + Base.Math._approx_cbrt(302.681*Float64(x))
-    nu_shift = ceil(Int, debye_cutoff - nu)
+    debye_cutoff = ceil(2.0 + 1.00035*x + Base.Math._approx_cbrt(302.681*Float64(x)))
+    nu_shift = ceil(Int, debye_cutoff - floor(nu))
     v = nu + nu_shift
     jnu = besseljy_debye(v, x)[1]
     jnup1 = besseljy_debye(v+1, x)[1]

src/bessely.jl

@@ -318,8 +318,8 @@ function bessely_positive_args(nu, x::T) where T
 
     # at this point x > 19.0 (for Float64) and fairly close to nu
     # shift nu down and use the debye expansion for Hankel function (valid x > nu) then use forward recurrence
-    nu_shift = ceil(nu) - floor(Int, -1.5 + x + Base.Math._approx_cbrt(-411*x)) + 4
-    v2 = nu - maximum((nu_shift, modf(nu)[1] + 1))
+    nu_shift = ceil(nu) - floor(Int, -1.5 + x + Base.Math._approx_cbrt(-411*x)) + 2
+    v2 = maximum((nu - nu_shift, modf(nu)[1] + 1))
     return besselj_up_recurrence(x, imag(hankel_debye(v2, x)), imag(hankel_debye(v2 - 1, x)), v2, nu)[1]
 end
 

src/hankel.jl

@@ -125,7 +125,7 @@ function besseljy_positive_args(nu::Real, x::T) where T
 
     # at this point x > 19.0 (for Float64) and fairly close to nu
     # shift nu down and use the debye expansion for Hankel function (valid x > nu) then use forward recurrence
-    nu_shift = floor(nu) - ceil(Int, -1.5 + x + Base.Math._approx_cbrt(-411*x))
+    nu_shift = ceil(nu) - floor(Int, -1.5 + x + Base.Math._approx_cbrt(-411*x)) + 2
     v2 = maximum((nu - nu_shift, modf(nu)[1] + 1))
 
     Hnu = hankel_debye(v2, x)

test/runtests.jl

@@ -8,3 +8,4 @@ import SpecialFunctions
 @time @testset "bessely" begin include("bessely_test.jl") end
 @time @testset "hankel" begin include("hankel_test.jl") end
 @time @testset "gamma" begin include("gamma_test.jl") end
+@time @testset "sphericalbessel" begin include("sphericalbessel_test.jl") end