Improve test coverage for corner casese

Author: jiahao

test/factorials.jl

@@ -11,22 +11,24 @@ using Base.Test
 @test_throws OverflowError factorial(1000,80)
 
 # derangement
-@test derangement(4) == 9
+@test derangement(4) == subfactorial(4) == 9
 @test derangement(24) == parse(BigInt,"228250211305338670494289")
 
 # doublefactorial
 @test doublefactorial(70) == parse(BigInt,"355044260642859198243475901411974413130137600000000")
+@test_throws DomainError doublefactorial(-1)
 
 # hyperfactorial
 @test hyperfactorial(8) == parse(BigInt,"55696437941726556979200000")
 
 # multifactorial
 @test multifactorial(40,2) == doublefactorial(40)
+@test_throws DomainError multifactorial(-1,1)
 
 # multinomial
 @test multinomial(1,4,4,2) == 34650
 
 # primorial
 @test primorial(17) == 510510
-
+@test_throws DomainError primorial(-1)
 

test/numbers.jl

@@ -8,6 +8,7 @@ using Base.Test
 # fibonacci
 @test fibonaccinum(5) == 5
 @test fibonaccinum(101) == parse(BigInt,"573147844013817084101")
+@test_throws DomainError fibonaccinum(-1)
 
 # lassalle
 @test lassallenum(14) == parse(BigInt,"270316008395632253340")
@@ -18,6 +19,7 @@ using Base.Test
 # lucas
 @test lucasnum(10) == 123
 @test lucasnum(100) == parse(BigInt,"792070839848372253127")
+@test_throws DomainError lucasnum(-1)
 
 # stirlings1
 @test sum([abs(stirlings1(8, i)) for i = 0:8]) == factorial(8)

test/partitions.jl

@@ -20,6 +20,7 @@ import Combinatorics: partitions, prevprod
 @test length(collect(partitions('a':'h',5))) == length(partitions('a':'h',5))
 
 # integer_partitions
+@test integer_partitions(0) == []
 @test integer_partitions(5) == Any[[1, 1, 1, 1, 1], [2, 1, 1, 1], [2, 2, 1], [3, 1, 1], [3, 2], [4, 1], [5]]
 @test_throws DomainError integer_partitions(-1)
 

test/youngdiagrams.jl

@@ -2,6 +2,7 @@ using Combinatorics
 using Base.Test
 
 @test ([5,4,2,2]\[2,1]) == ([5, 4, 2, 2],[2, 1])
+@test leglength([5,4,2,2], [2,1]) == leglength(([5, 4, 2, 2],[2, 1])) == 3
 @test isrimhook([4,3,2], [2,2,2])
 @test !isrimhook([4,3,2], [2,2,1])
 @test !isrimhook([4,3,2], [1,1])