Skip to content

Comments

Drop obsolete > and >= methods#198

Merged
stevengj merged 1 commit intoJuliaMath:masterfrom
lgoettgens:lg/comparison-invalidations
Feb 20, 2026
Merged

Drop obsolete > and >= methods#198
stevengj merged 1 commit intoJuliaMath:masterfrom
lgoettgens:lg/comparison-invalidations

Conversation

@lgoettgens
Copy link
Contributor

These are already provided by julia base, so there is no semantical difference.

However, dropping these methods reduces the number of invalidations of loading DecFP in julia 1.12.5 from 1580 to 517. In particular, the following invalidation trees are resolved:

 inserting >(dec::T, num::Union{Float16, Float32, Float64, AbstractIrrational, Integer, BigFloat}) where T<:DecimalFloatingPoint @ DecFP ~/code/julia/DecFP.jl/src/DecFP.jl:674 invalidated:
   backedges: 1: superseding >(x, y) @ Base operators.jl:425 with MethodInstance for >(::Any, ::Bool) (3 children)
              2: superseding >(x, y) @ Base operators.jl:425 with MethodInstance for >(::Any, ::UInt64) (7 children)
              3: superseding >(x, y) @ Base operators.jl:425 with MethodInstance for >(::Any, ::Integer) (53 children)
              4: superseding >(x, y) @ Base operators.jl:425 with MethodInstance for >(::Any, ::Int64) (88 children)

 inserting >=(dec::T, num::Union{Float16, Float32, Float64, Integer, BigFloat}) where T<:DecimalFloatingPoint @ DecFP ~/code/julia/DecFP.jl/src/DecFP.jl:676 invalidated:
   backedges: 1: superseding >=(x, y) @ Base operators.jl:472 with MethodInstance for >=(::Number, ::Int64) (4 children)
              2: superseding >=(x, y) @ Base operators.jl:472 with MethodInstance for >=(::Any, ::Int64) (865 children)

 inserting >(num::Union{Float16, Float32, Float64, AbstractIrrational, Integer, BigFloat}, dec::T) where T<:DecimalFloatingPoint @ DecFP ~/code/julia/DecFP.jl/src/DecFP.jl:681 invalidated:
   backedges: 1: superseding >(x, y) @ Base operators.jl:425 with MethodInstance for >(::Int64, ::Any) (1101 children)

@codecov
Copy link

codecov bot commented Feb 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.12%. Comparing base (a33cdff) to head (a058fb3).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #198      +/-   ##
==========================================
- Coverage   96.14%   96.12%   -0.03%     
==========================================
  Files           2        2              
  Lines         597      593       -4     
==========================================
- Hits          574      570       -4     
  Misses         23       23              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@stevengj stevengj merged commit 4d70d4a into JuliaMath:master Feb 20, 2026
11 checks passed
@lgoettgens lgoettgens deleted the lg/comparison-invalidations branch February 20, 2026 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants