Skip to content

remove dead code in src/math#238

Merged
JeffreySarnoff merged 3 commits intoJuliaMath:mainfrom
araujoms:deadcode
Mar 3, 2026
Merged

remove dead code in src/math#238
JeffreySarnoff merged 3 commits intoJuliaMath:mainfrom
araujoms:deadcode

Conversation

@araujoms
Copy link
Contributor

@araujoms araujoms commented Mar 1, 2026

I'm removing dead code from the repository, to improve maintainability and reduce invalidations. There are three categories that I'm removing here:

  1. Code that simply copied the fallback methods from Base, and thus was causing unnecessary invalidations.
  2. Code that wasn't exported or called from anywhere else in the package.
  3. Code that was commented out.

There is also plenty of dead code in other folders, but I thought it would be better to restrict this PR to src/math because it's already quite large.

@codecov
Copy link

codecov bot commented Mar 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 52.22%. Comparing base (f00b992) to head (bae2843).
⚠️ Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #238      +/-   ##
==========================================
+ Coverage   49.26%   52.22%   +2.96%     
==========================================
  Files          63       58       -5     
  Lines        3400     3144     -256     
==========================================
- Hits         1675     1642      -33     
+ Misses       1725     1502     -223     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@araujoms
Copy link
Contributor Author

araujoms commented Mar 2, 2026

Any particularly reason this one wasn't merged?

@JeffreySarnoff JeffreySarnoff merged commit 65a1391 into JuliaMath:main Mar 3, 2026
7 checks passed
@araujoms araujoms deleted the deadcode branch March 4, 2026 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants