Skip to content

add tests and fix bugs in modrem#250

Merged
JeffreySarnoff merged 1 commit intoJuliaMath:mainfrom
araujoms:modrem
Mar 4, 2026
Merged

add tests and fix bugs in modrem#250
JeffreySarnoff merged 1 commit intoJuliaMath:mainfrom
araujoms:modrem

Conversation

@araujoms
Copy link
Contributor

@araujoms araujoms commented Mar 3, 2026

As it turns out, the untested code was buggy.

@codecov
Copy link

codecov bot commented Mar 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.73%. Comparing base (674be88) to head (af3618f).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #250      +/-   ##
==========================================
+ Coverage   65.80%   67.73%   +1.92%     
==========================================
  Files          54       54              
  Lines        2445     2442       -3     
==========================================
+ Hits         1609     1654      +45     
+ Misses        836      788      -48     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JeffreySarnoff JeffreySarnoff merged commit babb216 into JuliaMath:main Mar 4, 2026
7 checks passed
@araujoms araujoms deleted the modrem branch March 4, 2026 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants