Change direction to enum (#18)

* New release!

* Change direction to enum

Co-authored-by: Danny Sharp <[email protected]>

Author: dannys4

src/FFTA.jl

@@ -10,14 +10,14 @@ include("algos.jl")
 function fft(x::AbstractVector{T}) where {T}
     y = similar(x)
     g = CallGraph{T}(length(x))
-    fft!(y, x, 1, 1, FFT_FORWARD(), g[1].type, g, 1)
+    fft!(y, x, 1, 1, FFT_FORWARD, g[1].type, g, 1)
     y
 end
 
 function fft(x::AbstractVector{T}) where {T <: Real}
     y = similar(x, Complex{T})
     g = CallGraph{Complex{T}}(length(x))
-    fft!(y, x, 1, 1, FFT_FORWARD(), g[1].type, g, 1)
+    fft!(y, x, 1, 1, FFT_FORWARD, g[1].type, g, 1)
     y
 end
 
@@ -29,26 +29,26 @@ function fft(x::AbstractMatrix{T}) where {T}
     g2 = CallGraph{T}(size(x,2))
 
     for k in 1:N
-        @views fft!(y1[:,k],  x[:,k], 1, 1, FFT_FORWARD(), g1[1].type, g1, 1)
+        @views fft!(y1[:,k],  x[:,k], 1, 1, FFT_FORWARD, g1[1].type, g1, 1)
     end
 
     for k in 1:M
-        @views fft!(y2[k,:], y1[k,:], 1, 1, FFT_FORWARD(), g2[1].type, g2, 1)
+        @views fft!(y2[k,:], y1[k,:], 1, 1, FFT_FORWARD, g2[1].type, g2, 1)
     end
     y2
 end
 
 function bfft(x::AbstractVector{T}) where {T}
     y = similar(x)
     g = CallGraph{T}(length(x))
-    fft!(y, x, 1, 1, FFT_BACKWARD(), g[1].type, g, 1)
+    fft!(y, x, 1, 1, FFT_BACKWARD, g[1].type, g, 1)
     y
 end
 
 function bfft(x::AbstractVector{T}) where {T <: Real}
     y = similar(x, Complex{T})
     g = CallGraph{Complex{T}}(length(x))
-    fft!(y, x, 1, 1, FFT_BACKWARD(), g[1].type, g, 1)
+    fft!(y, x, 1, 1, FFT_BACKWARD, g[1].type, g, 1)
     y
 end
 
@@ -60,11 +60,11 @@ function bfft(x::AbstractMatrix{T}) where {T}
     g2 = CallGraph{T}(size(x,2))
 
     for k in 1:N
-        @views fft!(y1[:,k],  x[:,k], 1, 1, FFT_BACKWARD(), g1[1].type, g1, 1)
+        @views fft!(y1[:,k],  x[:,k], 1, 1, FFT_BACKWARD, g1[1].type, g1, 1)
     end
 
     for k in 1:M
-        @views fft!(y2[k,:], y1[k,:], 1, 1, FFT_BACKWARD(), g2[1].type, g2, 1)
+        @views fft!(y2[k,:], y1[k,:], 1, 1, FFT_BACKWARD, g2[1].type, g2, 1)
     end
     y2
 end

src/algos.jl

@@ -8,12 +8,8 @@ end
 
 fft!(::AbstractVector{T}, ::AbstractVector{T}, ::Int, ::Int, ::Direction, ::AbstractFFTType, ::CallGraph{T}, ::Int) where {T} = nothing
 
-@inline function direction_sign(::FFT_BACKWARD)
-    1.
-end
-
-@inline function direction_sign(::FFT_FORWARD)
-    -1.
+@inline function direction_sign(d::Direction)
+    Int(d)
 end
 
 function (g::CallGraph{T})(out::AbstractVector{T}, in::AbstractVector{U}, start_out::Int, start_in::Int, v::Direction, t::AbstractFFTType, idx::Int) where {T,U}

src/callgraph.jl

@@ -1,6 +1,4 @@
-abstract type Direction end
-struct FFT_FORWARD <: Direction end
-struct FFT_BACKWARD <: Direction end
+@enum Direction FFT_FORWARD=-1 FFT_BACKWARD=1
 
 abstract type AbstractFFTType end