Skip to content

Experiment: raise 1.6 compat to test CI failures#111

Merged
dannys4 merged 1 commit intoJuliaMath:mainfrom
wheeheee:patch-1
Feb 26, 2026
Merged

Experiment: raise 1.6 compat to test CI failures#111
dannys4 merged 1 commit intoJuliaMath:mainfrom
wheeheee:patch-1

Conversation

@wheeheee
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Feb 26, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.85%. Comparing base (973fad1) to head (809838a).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #111      +/-   ##
==========================================
+ Coverage   98.66%   98.85%   +0.19%     
==========================================
  Files           4        4              
  Lines         525      526       +1     
==========================================
+ Hits          518      520       +2     
+ Misses          7        6       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dannys4
Copy link
Collaborator

dannys4 commented Feb 26, 2026

Bizarre. I'll merge this.

@dannys4 dannys4 added this pull request to the merge queue Feb 26, 2026
Merged via the queue into JuliaMath:main with commit 4230ac7 Feb 26, 2026
7 checks passed
@wheeheee wheeheee deleted the patch-1 branch February 26, 2026 03:57
@wheeheee
Copy link
Contributor Author

The 1.6.6 -> 1.6.7 commit diff has JuliaLang/julia#45289, a fix for JuliaLang/julia#45282.
It all makes sense now, because #107 adds the only invocation of copyto!(dest, Rdest::CartesianIndices, src, Rsrc::CartesianIndices) in this package.

@dannys4
Copy link
Collaborator

dannys4 commented Feb 26, 2026

that's nuts.

@wheeheee
Copy link
Contributor Author

The bug or the fix? 👀

@dannys4
Copy link
Collaborator

dannys4 commented Feb 26, 2026

that they happened to patch this in the bug fix right before the version I used.... Just serendipitous is all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants