Skip to content

specialize signbit(::FixedDecimal) #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

specialize signbit(::FixedDecimal) #72

wants to merge 1 commit into from

Conversation

lcontento
Copy link

The default implementation of signbit is quite slow for BigInt and Int128.
MWE:

using FixedPointDecimals
using BenchmarkTools

signbit2(x) = signbit(x.i);

x = FixedDecimal{BigInt, 10}(1);
@btime signbit($x);
@btime signbit2($x);

x = FixedDecimal{Int128, 10}(1);
@btime signbit($x);
@btime signbit2($x);

@lcontento
specialize signbit(::FixedDecimal)
3b7e4db 
faster than the default implementation for BigInts and Int128s
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lcontento