Skip to content

Commit 00ac41e

Browse files
committed
rethinking default logdensity
1 parent f8d36f5 commit 00ac41e

File tree

1 file changed

+4
-6
lines changed

1 file changed

+4
-6
lines changed

src/density.jl

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -78,15 +78,13 @@ Define a new measure in terms of a density `f` over some measure `base`. If
7878
# TODO: `density` and `logdensity` functions for `DensityMeasure`
7979

8080
function logdensity::AbstractMeasure, ν::AbstractMeasure, x)
81-
= basemeasure(μ)
82-
= basemeasure(ν)
81+
α = representative(μ)
82+
β = representative(ν)
8383

84-
result = logdensity(μ,x) + logdensity(bμ,x)
85-
result -= logdensity(ν,x) + logdensity(bν, x)
86-
result += _logdensity(basemeasure(bμ), basemeasure(bν), x)
84+
logdensity(μ, α, x) - logdensity(ν, β, x) + logdensity(α, β, x)
8785
end
8886

89-
_logdensity(::Lebesgue{ℝ}, ::Lebesgue{ℝ}, x) = zero(x)
87+
logdensity(::Lebesgue{ℝ}, ::Lebesgue{ℝ}, x) = zero(x)
9088

9189
export density
9290

0 commit comments

Comments
 (0)