move MakieCore and ChainRulesCore code to extensions (#479)

Author: Kristoffer Carlsson

Project.toml

@@ -10,13 +10,23 @@ LinearAlgebra = "37e2e46d-f89d-539d-b4ee-838fcccc9c8e"
 MakieCore = "20f20a25-4f0e-4fdf-b5d1-57303727442b"
 RecipesBase = "3cdcf5f2-1ef4-517c-9805-6587b60abb01"
 
+[weakdeps]
+ChainRulesCore = "d360d2e6-b24c-11e9-a2a3-2a2ae2dbcce4"
+MakieCore = "20f20a25-4f0e-4fdf-b5d1-57303727442b"
+
+[extensions]
+PolynomialsChainRulesCoreExt = "ChainRulesCore"
+PolynomialsMakieCoreExt = "MakieCore"
+
 [compat]
 ChainRulesCore = "1"
 MakieCore = "0.6"
 RecipesBase = "0.7, 0.8, 1"
 julia = "1.6"
 
 [extras]
+ChainRulesCore = "d360d2e6-b24c-11e9-a2a3-2a2ae2dbcce4"
+MakieCore = "20f20a25-4f0e-4fdf-b5d1-57303727442b"
 ChainRulesTestUtils = "cdddcdb0-9152-4a09-a978-84456f9df70a"
 DualNumbers = "fa6b7ba4-c1ee-5f82-b5fc-ecf0adba8f74"
 LinearAlgebra = "37e2e46d-f89d-539d-b4ee-838fcccc9c8e"
@@ -26,4 +36,4 @@ SpecialFunctions = "276daf66-3868-5448-9aa4-cd146d93841b"
 Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"
 
 [targets]
-test = ["DualNumbers", "LinearAlgebra", "SparseArrays", "OffsetArrays", "SpecialFunctions", "Test"]
+test = ["ChainRulesCore", "DualNumbers", "LinearAlgebra", "SparseArrays", "OffsetArrays", "SpecialFunctions", "Test"]

src/chain_rules.jl renamed to ext/PolynomialsChainRulesCoreExt.jl

@@ -1,3 +1,6 @@
+module PolynomialsChainRulesCoreExt
+
+using Polynomials
 import ChainRulesCore
 
 function ChainRulesCore.frule(
@@ -9,8 +12,9 @@ function ChainRulesCore.frule(
     p(x), derivative(p)(x)*Δx
 end
 
-
 function ChainRulesCore.rrule(p::AbstractPolynomial, x)
     _pullback(ΔΩ) = (ChainRulesCore.NoTangent(), derivative(p)(x))
     return (p(x), _pullback)
 end
+
+end

src/makie.jl renamed to ext/PolynomialsMakieCoreExt.jl

@@ -1,8 +1,13 @@
+module PolynomialsMakieCoreExt
+
+using Polynomials
 import MakieCore
 
-function MakieCore.convert_arguments(P::Type{<:MakieCore.XYBased}, p::AbstractPolynomial) 
-    xs = poly_interval(p)
+function MakieCore.convert_arguments(P::Type{<:MakieCore.XYBased}, p::AbstractPolynomial)
+    xs = Polynomials.poly_interval(p)
     return MakieCore.convert_arguments(P, xs, p.(xs))
 end
 
 MakieCore.plottype(p::AbstractPolynomial) = MakieCore.Lines
+
+end

src/Polynomials.jl

@@ -7,7 +7,6 @@ import Base: evalpoly
 include("abstract.jl")
 include("show.jl")
 include("plots.jl")
-include("makie.jl")
 include("contrib.jl")
 
 # Interface for all AbstractPolynomials
@@ -35,7 +34,12 @@ include("rational-functions/plot-recipes.jl")
 
 # compat; opt-in with `using Polynomials.PolyCompat`
 include("polynomials/Poly.jl")
-include("chain_rules.jl")
+
+if !isdefined(Base, :get_extension)
+    include("../ext/PolynomialsChainRulesCoreExt.jl")
+    include("../ext/PolynomialsMakieCoreExt.jl")
+end
+
 include("precompiles.jl")
 
 end # module